# \[PATCH 8/8\] drivers: regulator: 88pm800: fix warning same module names

- Subsystems: THE REST, VOLTAGE AND CURRENT REGULATOR FRAMEWORK
- Maintainers: Linus Torvalds, Liam Girdwood, Mark Brown
- List: linux-fbdev
- 3 messages, 2 authors
- Page: https://ratatoskr.run/linux-fbdev/2019/06/5619655/t

## \[PATCH 8/8\] drivers: regulator: 88pm800: fix warning same module names

- From: Anders Roxell \<hidden\>
- Date: 2019-06-06 09:47:48 
- Message: https://ratatoskr.run/linux-fbdev/2019/06/5619655.md

```text
When building with CONFIG_MFD_88PM800 and CONFIG_REGULATOR_88PM800
enabled as loadable modules, we see the following warning:

warning: same module names found:
  drivers/regulator/88pm800.ko
  drivers/mfd/88pm800.ko

Rework to rename the name.

Signed-off-by: Anders Roxell <redacted>
---
 drivers/regulator/Makefile | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/regulator/Makefile b/drivers/regulator/Makefile
index 76e78fa449a2..6906938071f5 100644
--- a/drivers/regulator/Makefile
+++ b/drivers/regulator/Makefile
@@ -11,7 +11,8 @@ obj-$(CONFIG_REGULATOR_VIRTUAL_CONSUMER) += virtual.o
 obj-$(CONFIG_REGULATOR_USERSPACE_CONSUMER) += userspace-consumer.o
 
 obj-$(CONFIG_REGULATOR_88PG86X) += 88pg86x.o
-obj-$(CONFIG_REGULATOR_88PM800) += 88pm800.o
+obj-$(CONFIG_REGULATOR_88PM800) += 88pm800-regulator.o
+88pm800-regulator-objs		:= 88pm800.o
 obj-$(CONFIG_REGULATOR_88PM8607) += 88pm8607.o
 obj-$(CONFIG_REGULATOR_CPCAP) += cpcap-regulator.o
 obj-$(CONFIG_REGULATOR_AAT2870) += aat2870-regulator.o
-- 
2.20.1
```

## Re: \[PATCH 8/8\] drivers: regulator: 88pm800: fix warning same module names

- From: Mark Brown \<broonie@kernel.org\>
- Date: 2019-06-06 11:00:12 
- Message: https://ratatoskr.run/linux-fbdev/2019/06/5619729.md

```text
On Thu, Jun 06, 2019 at 11:47:36AM +0200, Anders Roxell wrote:

>  obj-$(CONFIG_REGULATOR_88PG86X) += 88pg86x.o
> -obj-$(CONFIG_REGULATOR_88PM800) += 88pm800.o
> +obj-$(CONFIG_REGULATOR_88PM800) += 88pm800-regulator.o
> +88pm800-regulator-objs		:= 88pm800.o

Don't do this, no need for this driver to look different to all the
others in the Makefile - just rename the whole file.
```

## Re: \[PATCH 8/8\] drivers: regulator: 88pm800: fix warning same module names

- From: Anders Roxell \<hidden\>
- Date: 2019-06-10 13:02:04 
- Message: https://ratatoskr.run/linux-fbdev/2019/06/5623457.md

```text
On Thu, 6 Jun 2019 at 13:00, Mark Brown [ref] wrote:
>
> On Thu, Jun 06, 2019 at 11:47:36AM +0200, Anders Roxell wrote:
>
> >  obj-$(CONFIG_REGULATOR_88PG86X) += 88pg86x.o
> > -obj-$(CONFIG_REGULATOR_88PM800) += 88pm800.o
> > +obj-$(CONFIG_REGULATOR_88PM800) += 88pm800-regulator.o
> > +88pm800-regulator-objs               := 88pm800.o
>
> Don't do this, no need for this driver to look different to all the
> others in the Makefile - just rename the whole file.

Thank you for your review, I'll rework and resend v2 shortly.

Cheers,
Anders
```