# \[PATCH\] omapfb: Fix potential NULL pointer dereference in kmalloc

- Subsystems: FRAMEBUFFER LAYER, OMAP DISPLAY SUBSYSTEM and FRAMEBUFFER SUPPORT (DSS2), THE REST
- Maintainers: Helge Deller, Linus Torvalds
- List: linux-fbdev
- 2 messages, 2 authors
- Page: https://ratatoskr.run/linux-fbdev/2019/03/5529044/t

## \[PATCH\] omapfb: Fix potential NULL pointer dereference in kmalloc

- From: Aditya Pakki \<hidden\>
- Date: 2019-03-02 20:40:19 
- Message: https://ratatoskr.run/linux-fbdev/2019/03/5529044.md

```text
Memory allocated, using kmalloc, for new_compat may fail. This patch
checks for such an error and prevents potential NULL pointer
dereference.

Signed-off-by: Aditya Pakki <redacted>
---
 drivers/video/fbdev/omap2/omapfb/dss/omapdss-boot-init.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/drivers/video/fbdev/omap2/omapfb/dss/omapdss-boot-init.c b/drivers/video/fbdev/omap2/omapfb/dss/omapdss-boot-init.c
index 136d30484d02..0592c436b2da 100644
--- a/drivers/video/fbdev/omap2/omapfb/dss/omapdss-boot-init.c
+++ b/drivers/video/fbdev/omap2/omapfb/dss/omapdss-boot-init.c
@@ -111,6 +111,8 @@ static void __init omapdss_omapify_node(struct device_node *node)
 
 	new_len = prop->length + strlen(prefix) * num_strs;
 	new_compat = kmalloc(new_len, GFP_KERNEL);
+	if (!new_compat)
+		return;
 
 	omapdss_prefix_strcpy(new_compat, new_len, prop->value, prop->length);
 
-- 
2.17.1
```

## Re: \[PATCH\] omapfb: Fix potential NULL pointer dereference in kmalloc

- From: Bartlomiej Zolnierkiewicz \<hidden\>
- Date: 2019-04-01 13:01:53 
- Message: https://ratatoskr.run/linux-fbdev/2019/04/5556522.md

```text

On 03/02/2019 09:40 PM, Aditya Pakki wrote:
> Memory allocated, using kmalloc, for new_compat may fail. This patch
> checks for such an error and prevents potential NULL pointer
> dereference.
> 
> Signed-off-by: Aditya Pakki <redacted>

Patch queued for v5.2, thanks.

Best regards,
--
Bartlomiej Zolnierkiewicz
Samsung R&D Institute Poland
Samsung Electronics
```