[PATCH] video/macfb: Call fb_invert_cmaps()

Subsystems: framebuffer layer, the rest

STALE2696d

2 messages, 2 authors, 2019-04-01 · open the first message on its own page

[PATCH] video/macfb: Call fb_invert_cmaps()

From: Finn Thain <hidden>
Date: 2019-02-17 23:30:02

The 'inverse' parameter has no effect otherwise. Remove set-but-unused
variable.

Cc: linux-m68k@lists.linux-m68k.org
Signed-off-by: Finn Thain <redacted>
---
 drivers/video/fbdev/macfb.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/video/fbdev/macfb.c b/drivers/video/fbdev/macfb.c
index 00671055a611..37c56c45ee39 100644
--- a/drivers/video/fbdev/macfb.c
+++ b/drivers/video/fbdev/macfb.c
@@ -136,7 +136,6 @@ static struct fb_fix_screeninfo macfb_fix = {
 static void *slot_addr;
 static struct fb_info fb_info;
 static u32 pseudo_palette[16];
-static int inverse;
 static int vidtest;
 
 /*
@@ -520,7 +519,7 @@ static void __init macfb_setup(char *options)
 			continue;
 
 		if (!strcmp(this_opt, "inverse"))
-			inverse = 1;
+			fb_invert_cmaps();
 		else
 			if (!strcmp(this_opt, "vidtest"))
 				vidtest = 1; /* enable experimental CLUT code */
-- 
2.19.2

Re: [PATCH] video/macfb: Call fb_invert_cmaps()

From: Bartlomiej Zolnierkiewicz <hidden>
Date: 2019-04-01 12:04:13

On 02/18/2019 12:25 AM, Finn Thain wrote:
The 'inverse' parameter has no effect otherwise. Remove set-but-unused
variable.

Cc: linux-m68k@lists.linux-m68k.org
Signed-off-by: Finn Thain <redacted>
Patch queued for v5.2, thanks.

Best regards,
--
Bartlomiej Zolnierkiewicz
Samsung R&D Institute Poland
Samsung Electronics
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help