[PATCH] video: fbdev: vesafb: fix indentation issue

Subsystems: framebuffer layer, the rest

STALE2749d

3 messages, 3 authors, 2019-04-01 · open the first message on its own page

[PATCH] video: fbdev: vesafb: fix indentation issue

From: Colin King <hidden>
Date: 2019-02-12 13:29:12 

From: Colin Ian King <redacted>

There are a couple of statements that are indented too deeply, fix
this by removing tabs. Also add a space after a comma to clean up
a cppcheck warning.

Signed-off-by: Colin Ian King <redacted>
---
 drivers/video/fbdev/vesafb.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/video/fbdev/vesafb.c b/drivers/video/fbdev/vesafb.c
index 528fe917dd49..b7388e25aa2a 100644
--- a/drivers/video/fbdev/vesafb.c
+++ b/drivers/video/fbdev/vesafb.c
@@ -336,8 +336,8 @@ static int vesafb_probe(struct platform_device *dev)
 		printk(KERN_INFO "vesafb: pmi: set display start = %p, set palette = %p\n",pmi_start,pmi_pal);
 		if (pmi_base[3]) {
 			printk(KERN_INFO "vesafb: pmi: ports = ");
-				for (i = pmi_base[3]/2; pmi_base[i] != 0xffff; i++)
-					printk("%x ",pmi_base[i]);
+			for (i = pmi_base[3]/2; pmi_base[i] != 0xffff; i++)
+				printk("%x ", pmi_base[i]);
 			printk("\n");
 			if (pmi_base[i] != 0xffff) {
 				/*
-- 
2.20.1

Re: [PATCH] video: fbdev: vesafb: fix indentation issue

From: Joe Perches <joe@perches.com>
Date: 2019-02-15 10:00:33 

On Tue, 2019-02-12 at 13:29 +0000, Colin King wrote:
quoted hunk
From: Colin Ian King <redacted>

There are a couple of statements that are indented too deeply, fix
this by removing tabs. Also add a space after a comma to clean up
a cppcheck warning.

Signed-off-by: Colin Ian King <redacted>
---
 drivers/video/fbdev/vesafb.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/video/fbdev/vesafb.c b/drivers/video/fbdev/vesafb.c
index 528fe917dd49..b7388e25aa2a 100644
--- a/drivers/video/fbdev/vesafb.c
+++ b/drivers/video/fbdev/vesafb.c
@@ -336,8 +336,8 @@ static int vesafb_probe(struct platform_device *dev)
 		printk(KERN_INFO "vesafb: pmi: set display start = %p, set palette = %p\n",pmi_start,pmi_pal);
 		if (pmi_base[3]) {
 			printk(KERN_INFO "vesafb: pmi: ports = ");
-				for (i = pmi_base[3]/2; pmi_base[i] != 0xffff; i++)
-					printk("%x ",pmi_base[i]);
+			for (i = pmi_base[3]/2; pmi_base[i] != 0xffff; i++)
+				printk("%x ", pmi_base[i]);
 			printk("\n");
 			if (pmi_base[i] != 0xffff) {
 				/*
Perhaps you could also use pr_cont too because otherwise this
emits each printk on separate lines.

Re: [PATCH] video: fbdev: vesafb: fix indentation issue

From: Bartlomiej Zolnierkiewicz <hidden>
Date: 2019-04-01 11:49:02 

On 02/12/2019 02:29 PM, Colin King wrote:
From: Colin Ian King <redacted>

There are a couple of statements that are indented too deeply, fix
this by removing tabs. Also add a space after a comma to clean up
a cppcheck warning.

Signed-off-by: Colin Ian King <redacted>
Patch queued for v5.2, thanks.

Best regards,
--
Bartlomiej Zolnierkiewicz
Samsung R&D Institute Poland
Samsung Electronics
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help