# \[PATCH -next\] video: fbdev: Fix potential NULL pointer dereference

- Subsystems: FRAMEBUFFER LAYER, FRAMEBUFFER CORE, THE REST
- Maintainers: Helge Deller, Simona Vetter, Linus Torvalds
- List: linux-fbdev
- 2 messages, 2 authors
- Page: https://ratatoskr.run/linux-fbdev/2019/01/5498832/t

## \[PATCH -next\] video: fbdev: Fix potential NULL pointer dereference

- From: YueHaibing \<hidden\>
- Date: 2019-01-30 10:16:43 
- Message: https://ratatoskr.run/linux-fbdev/2019/01/5498832.md

```text
There is a potential NULL pointer dereference in case
fb_create_modedb() fails and returns NULL.

Signed-off-by: YueHaibing <redacted>
---
 drivers/video/fbdev/core/fbmon.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/drivers/video/fbdev/core/fbmon.c b/drivers/video/fbdev/core/fbmon.c
index dd31289..3558a70 100644
--- a/drivers/video/fbdev/core/fbmon.c
+++ b/drivers/video/fbdev/core/fbmon.c
@@ -978,6 +978,8 @@ void fb_edid_to_monspecs(unsigned char *edid, struct fb_monspecs *specs)
 	get_monspecs(edid, specs);
 
 	specs->modedb = fb_create_modedb(edid, &specs->modedb_len, specs);
+	if (!specs->modedb)
+		return;
 
 	/*
 	 * Workaround for buggy EDIDs that sets that the first
-- 
2.7.0
```

## Re: \[PATCH -next\] video: fbdev: Fix potential NULL pointer dereference

- From: Bartlomiej Zolnierkiewicz \<hidden\>
- Date: 2019-02-08 18:13:51 
- Message: https://ratatoskr.run/linux-fbdev/2019/02/5507681.md

```text

On 01/30/2019 11:16 AM, YueHaibing wrote:
> There is a potential NULL pointer dereference in case
> fb_create_modedb() fails and returns NULL.
> 
> Signed-off-by: YueHaibing <redacted>

Patch queued for v5.1, thanks.

Best regards,
--
Bartlomiej Zolnierkiewicz
Samsung R&D Institute Poland
Samsung Electronics
```