# Re: \[PATCH\] video: offb: Pass actual name in offb\_init\_palette\_hacks

- From: Rob Herring \<robh@kernel.org\>
- Date: 2019-01-07 17:31:27 
- List: linux-fbdev
- Page: https://ratatoskr.run/linux-fbdev/2019/01/5476548
- Thread: https://ratatoskr.run/stable/2018/12/5456565/t.md

```text
On Wed, Jan 2, 2019 at 2:03 PM Mathieu Malaterre [ref] wrote:
>
> Bartlomiej,
>
> Do you need an Acked-by from Rob, or can you take it in the next round
> of fixes for v4.20 ?

Sorry, I missed this.

>
> Just to repeat myself, previous code would call
> offb_init_palette_hacks(), which in turn would do:
>
>        if (dp && !strncmp(name, "ATY,Rage128", 11)) {
>
> with name=NULL.

I prefer to fix this properly using node name helper in
offb_init_palette_hacks(). I'll send a patch shortly.


Rob
```