# \[PATCH 1/2\] video: lcd: Remove useless BACKLIGHT\_LCD\_SUPPORT kernel symbol

- Subsystems: FRAMEBUFFER LAYER, BACKLIGHT CLASS/SUBSYSTEM, DRM DRIVER FOR NVIDIA GEFORCE/QUADRO GPUS, DRM DRIVERS, DRM DRIVERS AND MISC GPU PATCHES, DRM DRIVERS FOR BRIDGE CHIPS, DRM DRIVERS FOR FREESCALE DCU, DRM DRIVERS FOR TI LCDC, INTEL DRM I915 DRIVER (Meteor Lake, DG2 and older excluding Poulsbo, Moorestown and derivative), STAGING SUBSYSTEM, THE REST, USB SUBSYSTEM
- Maintainers: Helge Deller, Lee Jones, Daniel Thompson, Jingoo Han, Lyude Paul, Danilo Krummrich, David Airlie, Simona Vetter, Maarten Lankhorst, Maxime Ripard, Thomas Zimmermann, Andrzej Hajda, Neil Armstrong, Robert Foss, Stefan Agner, Alison Wang, Jyri Sarha, Tomi Valkeinen, Jani Nikula, Joonas Lahtinen, Rodrigo Vivi, Tvrtko Ursulin, Greg Kroah-Hartman, Linus Torvalds
- List: linux-fbdev
- 4 messages, 2 authors
- Page: https://ratatoskr.run/linux-fbdev/2018/12/9152141/t

## \[PATCH 1/2\] video: lcd: Remove useless BACKLIGHT\_LCD\_SUPPORT kernel symbol

- From: Alexander Shiyan \<hidden\>
- Date: 2018-12-16 05:02:58 
- Message: https://ratatoskr.run/linux-fbdev/2018/12/9152141.md

```text
Symbol BACKLIGHT_LCD_SUPPORT affecting anything, except enabling
the backlight & LCD Kconfig menu. The patch removes this symbol as
useless and converts it into a menu.

Signed-off-by: Alexander Shiyan <redacted>
---
 arch/unicore32/Kconfig            |  1 -
 drivers/gpu/drm/Kconfig           |  2 --
 drivers/gpu/drm/bridge/Kconfig    |  1 -
 drivers/gpu/drm/fsl-dcu/Kconfig   |  1 -
 drivers/gpu/drm/i915/Kconfig      |  1 -
 drivers/gpu/drm/nouveau/Kconfig   |  1 -
 drivers/gpu/drm/shmobile/Kconfig  |  1 -
 drivers/gpu/drm/tilcdc/Kconfig    |  1 -
 drivers/staging/olpc_dcon/Kconfig |  1 -
 drivers/usb/misc/Kconfig          |  1 -
 drivers/video/backlight/Kconfig   | 10 ++--------
 drivers/video/fbdev/Kconfig       |  5 -----
 12 files changed, 2 insertions(+), 24 deletions(-)

diff --git a/arch/unicore32/Kconfig b/arch/unicore32/Kconfig
index a4c0515..afeea3d 100644
--- a/arch/unicore32/Kconfig
+++ b/arch/unicore32/Kconfig
@@ -211,7 +211,6 @@ config I2C_EEPROM_AT24
 
 config LCD_BACKLIGHT
 	tristate "LCD Backlight support"
-	select BACKLIGHT_LCD_SUPPORT
 	select BACKLIGHT_PWM
 
 endmenu
diff --git a/drivers/gpu/drm/Kconfig b/drivers/gpu/drm/Kconfig
index 4385f00..ef442a7 100644
--- a/drivers/gpu/drm/Kconfig
+++ b/drivers/gpu/drm/Kconfig
@@ -198,7 +198,6 @@ config DRM_RADEON
 	select POWER_SUPPLY
 	select HWMON
 	select BACKLIGHT_CLASS_DEVICE
-	select BACKLIGHT_LCD_SUPPORT
 	select INTERVAL_TREE
 	help
 	  Choose this option if you have an ATI Radeon graphics card.  There
@@ -219,7 +218,6 @@ config DRM_AMDGPU
 	select POWER_SUPPLY
 	select HWMON
 	select BACKLIGHT_CLASS_DEVICE
-	select BACKLIGHT_LCD_SUPPORT
 	select INTERVAL_TREE
 	select CHASH
 	help
diff --git a/drivers/gpu/drm/bridge/Kconfig b/drivers/gpu/drm/bridge/Kconfig
index 9eeb8ef..0f724e2 100644
--- a/drivers/gpu/drm/bridge/Kconfig
+++ b/drivers/gpu/drm/bridge/Kconfig
@@ -75,7 +75,6 @@ config DRM_PARADE_PS8622
 	depends on OF
 	select DRM_PANEL
 	select DRM_KMS_HELPER
-	select BACKLIGHT_LCD_SUPPORT
 	select BACKLIGHT_CLASS_DEVICE
 	---help---
 	  Parade eDP-LVDS bridge chip driver.
diff --git a/drivers/gpu/drm/fsl-dcu/Kconfig b/drivers/gpu/drm/fsl-dcu/Kconfig
index 14a72c4..dc82588 100644
--- a/drivers/gpu/drm/fsl-dcu/Kconfig
+++ b/drivers/gpu/drm/fsl-dcu/Kconfig
@@ -2,7 +2,6 @@ config DRM_FSL_DCU
 	tristate "DRM Support for Freescale DCU"
 	depends on DRM && OF && ARM && COMMON_CLK
 	select BACKLIGHT_CLASS_DEVICE
-	select BACKLIGHT_LCD_SUPPORT
 	select DRM_KMS_HELPER
 	select DRM_KMS_CMA_HELPER
 	select DRM_PANEL
diff --git a/drivers/gpu/drm/i915/Kconfig b/drivers/gpu/drm/i915/Kconfig
index 33a458b..90d406e73 100644
--- a/drivers/gpu/drm/i915/Kconfig
+++ b/drivers/gpu/drm/i915/Kconfig
@@ -15,7 +15,6 @@ config DRM_I915
 	select IRQ_WORK
 	# i915 depends on ACPI_VIDEO when ACPI is enabled
 	# but for select to work, need to select ACPI_VIDEO's dependencies, ick
-	select BACKLIGHT_LCD_SUPPORT if ACPI
 	select BACKLIGHT_CLASS_DEVICE if ACPI
 	select INPUT if ACPI
 	select ACPI_VIDEO if ACPI
diff --git a/drivers/gpu/drm/nouveau/Kconfig b/drivers/gpu/drm/nouveau/Kconfig
index 4b75ad40..a0238bf 100644
--- a/drivers/gpu/drm/nouveau/Kconfig
+++ b/drivers/gpu/drm/nouveau/Kconfig
@@ -11,7 +11,6 @@ config DRM_NOUVEAU
 	select MXM_WMI if ACPI && X86
 	select POWER_SUPPLY
 	# Similar to i915, we need to select ACPI_VIDEO and it's dependencies
-	select BACKLIGHT_LCD_SUPPORT if ACPI && X86
 	select BACKLIGHT_CLASS_DEVICE if ACPI && X86
 	select INPUT if ACPI && X86
 	select THERMAL if ACPI && X86
diff --git a/drivers/gpu/drm/shmobile/Kconfig b/drivers/gpu/drm/shmobile/Kconfig
index 61bbe8e..e2a6c82 100644
--- a/drivers/gpu/drm/shmobile/Kconfig
+++ b/drivers/gpu/drm/shmobile/Kconfig
@@ -4,7 +4,6 @@ config DRM_SHMOBILE
 	depends on DRM && ARM
 	depends on ARCH_SHMOBILE || COMPILE_TEST
 	select BACKLIGHT_CLASS_DEVICE
-	select BACKLIGHT_LCD_SUPPORT
 	select DRM_KMS_HELPER
 	select DRM_KMS_CMA_HELPER
 	select DRM_GEM_CMA_HELPER
diff --git a/drivers/gpu/drm/tilcdc/Kconfig b/drivers/gpu/drm/tilcdc/Kconfig
index 5259804..cb7df20 100644
--- a/drivers/gpu/drm/tilcdc/Kconfig
+++ b/drivers/gpu/drm/tilcdc/Kconfig
@@ -8,7 +8,6 @@ config DRM_TILCDC
 	select DRM_PANEL_BRIDGE
 	select VIDEOMODE_HELPERS
 	select BACKLIGHT_CLASS_DEVICE
-	select BACKLIGHT_LCD_SUPPORT
 	help
 	  Choose this option if you have an TI SoC with LCDC display
 	  controller, for example AM33xx in beagle-bone, DA8xx, or
diff --git a/drivers/staging/olpc_dcon/Kconfig b/drivers/staging/olpc_dcon/Kconfig
index 192cc8d..c91a56f 100644
--- a/drivers/staging/olpc_dcon/Kconfig
+++ b/drivers/staging/olpc_dcon/Kconfig
@@ -2,7 +2,6 @@ config FB_OLPC_DCON
 	tristate "One Laptop Per Child Display CONtroller support"
 	depends on OLPC && FB
 	depends on I2C
-	depends on BACKLIGHT_LCD_SUPPORT
 	depends on (GPIO_CS5535 || GPIO_CS5535=n)
 	select BACKLIGHT_CLASS_DEVICE
 	help
diff --git a/drivers/usb/misc/Kconfig b/drivers/usb/misc/Kconfig
index 68d2f2c..a86a80b 100644
--- a/drivers/usb/misc/Kconfig
+++ b/drivers/usb/misc/Kconfig
@@ -141,7 +141,6 @@ config USB_FTDI_ELAN
 
 config USB_APPLEDISPLAY
 	tristate "Apple Cinema Display support"
-	select BACKLIGHT_LCD_SUPPORT
 	select BACKLIGHT_CLASS_DEVICE
 	help
 	  Say Y here if you want to control the backlight of Apple Cinema
diff --git a/drivers/video/backlight/Kconfig b/drivers/video/backlight/Kconfig
index 71ee978..3fdc18e 100644
--- a/drivers/video/backlight/Kconfig
+++ b/drivers/video/backlight/Kconfig
@@ -2,13 +2,7 @@
 # Backlight & LCD drivers configuration
 #
 
-menuconfig BACKLIGHT_LCD_SUPPORT
-	bool "Backlight & LCD device support"
-	help
-	  Enable this to be able to choose the drivers for controlling the
-	  backlight and the LCD panel on some platforms, for example on PDAs.
-
-if BACKLIGHT_LCD_SUPPORT
+menu "Backlight & LCD device support"
 
 #
 # LCD
@@ -466,4 +460,4 @@ config BACKLIGHT_RAVE_SP
 
 endif # BACKLIGHT_CLASS_DEVICE
 
-endif # BACKLIGHT_LCD_SUPPORT
+endmenu
diff --git a/drivers/video/fbdev/Kconfig b/drivers/video/fbdev/Kconfig
index e413f54..0037d5e 100644
--- a/drivers/video/fbdev/Kconfig
+++ b/drivers/video/fbdev/Kconfig
@@ -186,7 +186,6 @@ config FB_MACMODES
 config FB_BACKLIGHT
 	bool
 	depends on FB
-	select BACKLIGHT_LCD_SUPPORT
 	select BACKLIGHT_CLASS_DEVICE
 
 config FB_MODE_HELPERS
@@ -281,7 +280,6 @@ config FB_ARMCLCD
 	select FB_CFB_IMAGEBLIT
 	select FB_MODE_HELPERS if OF
 	select VIDEOMODE_HELPERS if OF
-	select BACKLIGHT_LCD_SUPPORT if OF
 	select BACKLIGHT_CLASS_DEVICE if OF
 	help
 	  This framebuffer device driver is for the ARM PrimeCell PL110
@@ -315,7 +313,6 @@ config FB_ACORN
 config FB_CLPS711X
 	tristate "CLPS711X LCD support"
 	depends on FB && (ARCH_CLPS711X || COMPILE_TEST)
-	select BACKLIGHT_LCD_SUPPORT
 	select FB_MODE_HELPERS
 	select FB_SYS_FILLRECT
 	select FB_SYS_COPYAREA
@@ -343,7 +340,6 @@ config FB_SA1100
 config FB_IMX
 	tristate "Freescale i.MX1/21/25/27 LCD support"
 	depends on FB && ARCH_MXC
-	select BACKLIGHT_LCD_SUPPORT
 	select LCD_CLASS_DEVICE
 	select FB_CFB_FILLRECT
 	select FB_CFB_COPYAREA
@@ -2191,7 +2187,6 @@ config FB_MX3
 	tristate "MX3 Framebuffer support"
 	depends on FB && MX3_IPU
 	select BACKLIGHT_CLASS_DEVICE
-	select BACKLIGHT_LCD_SUPPORT
 	select FB_CFB_FILLRECT
 	select FB_CFB_COPYAREA
 	select FB_CFB_IMAGEBLIT
-- 
2.10.2
```

## \[PATCH 2/2\] video: lcd: Remove useless BACKLIGHT\_CLASS\_DEVICE dependencies

- From: Alexander Shiyan \<hidden\>
- Date: 2018-12-16 05:03:00 
- Message: https://ratatoskr.run/linux-fbdev/2018/12/9152137.md

```text
This patch removes dependencies on BACKLIGHT_CLASS_DEVICE for items
that are already placed under #ifdef BACKLIGHT_CLASS_DEVICE.

Signed-off-by: Alexander Shiyan <redacted>
---
 drivers/video/backlight/Kconfig | 25 ++++++++++++-------------
 1 file changed, 12 insertions(+), 13 deletions(-)

diff --git a/drivers/video/backlight/Kconfig b/drivers/video/backlight/Kconfig
index 3fdc18e..3ed1d90 100644
--- a/drivers/video/backlight/Kconfig
+++ b/drivers/video/backlight/Kconfig
@@ -193,7 +193,6 @@ config BACKLIGHT_IPAQ_MICRO
 
 config BACKLIGHT_LM3533
 	tristate "Backlight Driver for LM3533"
-	depends on BACKLIGHT_CLASS_DEVICE
 	depends on MFD_LM3533
 	help
 	  Say Y to enable the backlight driver for National Semiconductor / TI
@@ -317,7 +316,7 @@ config BACKLIGHT_ADP5520
 
 config BACKLIGHT_ADP8860
 	tristate "Backlight Driver for ADP8860/ADP8861/ADP8863 using WLED"
-	depends on BACKLIGHT_CLASS_DEVICE && I2C
+	depends on I2C
 	select NEW_LEDS
 	select LEDS_CLASS
 	help
@@ -329,7 +328,7 @@ config BACKLIGHT_ADP8860
 
 config BACKLIGHT_ADP8870
 	tristate "Backlight Driver for ADP8870 using WLED"
-	depends on BACKLIGHT_CLASS_DEVICE && I2C
+	depends on I2C
 	select NEW_LEDS
 	select LEDS_CLASS
 	help
@@ -347,28 +346,28 @@ config BACKLIGHT_88PM860X
 
 config BACKLIGHT_PCF50633
 	tristate "Backlight driver for NXP PCF50633 MFD"
-	depends on BACKLIGHT_CLASS_DEVICE && MFD_PCF50633
+	depends on MFD_PCF50633
 	help
 	  If you have a backlight driven by a NXP PCF50633 MFD, say Y here to
 	  enable its driver.
 
 config BACKLIGHT_AAT2870
 	tristate "AnalogicTech AAT2870 Backlight"
-	depends on BACKLIGHT_CLASS_DEVICE && MFD_AAT2870_CORE
+	depends on MFD_AAT2870_CORE
 	help
 	  If you have a AnalogicTech AAT2870 say Y to enable the
 	  backlight driver.
 
 config BACKLIGHT_LM3630A
 	tristate "Backlight Driver for LM3630A"
-	depends on BACKLIGHT_CLASS_DEVICE && I2C && PWM
+	depends on I2C && PWM
 	select REGMAP_I2C
 	help
 	  This supports TI LM3630A Backlight Driver
 
 config BACKLIGHT_LM3639
 	tristate "Backlight Driver for LM3639"
-	depends on BACKLIGHT_CLASS_DEVICE && I2C
+	depends on I2C
 	select REGMAP_I2C
 	select NEW_LEDS
 	select LEDS_CLASS
@@ -377,20 +376,20 @@ config BACKLIGHT_LM3639
 
 config BACKLIGHT_LP855X
 	tristate "Backlight driver for TI LP855X"
-	depends on BACKLIGHT_CLASS_DEVICE && I2C && PWM
+	depends on I2C && PWM
 	help
 	  This supports TI LP8550, LP8551, LP8552, LP8553, LP8555, LP8556 and
 	  LP8557 backlight driver.
 
 config BACKLIGHT_LP8788
 	tristate "Backlight driver for TI LP8788 MFD"
-	depends on BACKLIGHT_CLASS_DEVICE && MFD_LP8788 && PWM
+	depends on MFD_LP8788 && PWM
 	help
 	  This supports TI LP8788 backlight driver.
 
 config BACKLIGHT_OT200
 	tristate "Backlight driver for ot200 visualisation device"
-	depends on BACKLIGHT_CLASS_DEVICE && CS5535_MFGPT && GPIO_CS5535
+	depends on CS5535_MFGPT && GPIO_CS5535
 	help
 	  To compile this driver as a module, choose M here: the module will be
 	  called ot200_bl.
@@ -404,7 +403,7 @@ config BACKLIGHT_PANDORA
 
 config BACKLIGHT_SKY81452
 	tristate "Backlight driver for SKY81452"
-	depends on BACKLIGHT_CLASS_DEVICE && MFD_SKY81452
+	depends on MFD_SKY81452
 	help
 	  If you have a Skyworks SKY81452, say Y to enable the
 	  backlight driver.
@@ -414,14 +413,14 @@ config BACKLIGHT_SKY81452
 
 config BACKLIGHT_TPS65217
 	tristate "TPS65217 Backlight"
-	depends on BACKLIGHT_CLASS_DEVICE && MFD_TPS65217
+	depends on MFD_TPS65217
 	help
 	  If you have a Texas Instruments TPS65217 say Y to enable the
 	  backlight driver.
 
 config BACKLIGHT_AS3711
 	tristate "AS3711 Backlight"
-	depends on BACKLIGHT_CLASS_DEVICE && MFD_AS3711
+	depends on MFD_AS3711
 	help
 	  If you have an Austrian Microsystems AS3711 say Y to enable the
 	  backlight driver.
-- 
2.10.2
```

## Re: \[PATCH 2/2\] video: lcd: Remove useless BACKLIGHT\_CLASS\_DEVICE dependencies

- From: Daniel Thompson \<hidden\>
- Date: 2018-12-17 12:09:11 
- Message: https://ratatoskr.run/linux-fbdev/2018/12/9152158.md

```text
On Sun, Dec 16, 2018 at 08:02:47AM +0300, Alexander Shiyan wrote:
> This patch removes dependencies on BACKLIGHT_CLASS_DEVICE for items
> that are already placed under #ifdef BACKLIGHT_CLASS_DEVICE.

s/#ifdef/if/

Once that is fixed:
Acked-by: Daniel Thompson <redacted>

> 
> Signed-off-by: Alexander Shiyan <redacted>
> ---
>  drivers/video/backlight/Kconfig | 25 ++++++++++++-------------
>  1 file changed, 12 insertions(+), 13 deletions(-)
> 
> diff --git a/drivers/video/backlight/Kconfig b/drivers/video/backlight/Kconfig
> index 3fdc18e..3ed1d90 100644
> --- a/drivers/video/backlight/Kconfig
> +++ b/drivers/video/backlight/Kconfig
> @@ -193,7 +193,6 @@ config BACKLIGHT_IPAQ_MICRO
>  
>  config BACKLIGHT_LM3533
>  	tristate "Backlight Driver for LM3533"
> -	depends on BACKLIGHT_CLASS_DEVICE
>  	depends on MFD_LM3533
>  	help
>  	  Say Y to enable the backlight driver for National Semiconductor / TI
> @@ -317,7 +316,7 @@ config BACKLIGHT_ADP5520
>  
>  config BACKLIGHT_ADP8860
>  	tristate "Backlight Driver for ADP8860/ADP8861/ADP8863 using WLED"
> -	depends on BACKLIGHT_CLASS_DEVICE && I2C
> +	depends on I2C
>  	select NEW_LEDS
>  	select LEDS_CLASS
>  	help
> @@ -329,7 +328,7 @@ config BACKLIGHT_ADP8860
>  
>  config BACKLIGHT_ADP8870
>  	tristate "Backlight Driver for ADP8870 using WLED"
> -	depends on BACKLIGHT_CLASS_DEVICE && I2C
> +	depends on I2C
>  	select NEW_LEDS
>  	select LEDS_CLASS
>  	help
> @@ -347,28 +346,28 @@ config BACKLIGHT_88PM860X
>  
>  config BACKLIGHT_PCF50633
>  	tristate "Backlight driver for NXP PCF50633 MFD"
> -	depends on BACKLIGHT_CLASS_DEVICE && MFD_PCF50633
> +	depends on MFD_PCF50633
>  	help
>  	  If you have a backlight driven by a NXP PCF50633 MFD, say Y here to
>  	  enable its driver.
>  
>  config BACKLIGHT_AAT2870
>  	tristate "AnalogicTech AAT2870 Backlight"
> -	depends on BACKLIGHT_CLASS_DEVICE && MFD_AAT2870_CORE
> +	depends on MFD_AAT2870_CORE
>  	help
>  	  If you have a AnalogicTech AAT2870 say Y to enable the
>  	  backlight driver.
>  
>  config BACKLIGHT_LM3630A
>  	tristate "Backlight Driver for LM3630A"
> -	depends on BACKLIGHT_CLASS_DEVICE && I2C && PWM
> +	depends on I2C && PWM
>  	select REGMAP_I2C
>  	help
>  	  This supports TI LM3630A Backlight Driver
>  
>  config BACKLIGHT_LM3639
>  	tristate "Backlight Driver for LM3639"
> -	depends on BACKLIGHT_CLASS_DEVICE && I2C
> +	depends on I2C
>  	select REGMAP_I2C
>  	select NEW_LEDS
>  	select LEDS_CLASS
> @@ -377,20 +376,20 @@ config BACKLIGHT_LM3639
>  
>  config BACKLIGHT_LP855X
>  	tristate "Backlight driver for TI LP855X"
> -	depends on BACKLIGHT_CLASS_DEVICE && I2C && PWM
> +	depends on I2C && PWM
>  	help
>  	  This supports TI LP8550, LP8551, LP8552, LP8553, LP8555, LP8556 and
>  	  LP8557 backlight driver.
>  
>  config BACKLIGHT_LP8788
>  	tristate "Backlight driver for TI LP8788 MFD"
> -	depends on BACKLIGHT_CLASS_DEVICE && MFD_LP8788 && PWM
> +	depends on MFD_LP8788 && PWM
>  	help
>  	  This supports TI LP8788 backlight driver.
>  
>  config BACKLIGHT_OT200
>  	tristate "Backlight driver for ot200 visualisation device"
> -	depends on BACKLIGHT_CLASS_DEVICE && CS5535_MFGPT && GPIO_CS5535
> +	depends on CS5535_MFGPT && GPIO_CS5535
>  	help
>  	  To compile this driver as a module, choose M here: the module will be
>  	  called ot200_bl.
> @@ -404,7 +403,7 @@ config BACKLIGHT_PANDORA
>  
>  config BACKLIGHT_SKY81452
>  	tristate "Backlight driver for SKY81452"
> -	depends on BACKLIGHT_CLASS_DEVICE && MFD_SKY81452
> +	depends on MFD_SKY81452
>  	help
>  	  If you have a Skyworks SKY81452, say Y to enable the
>  	  backlight driver.
> @@ -414,14 +413,14 @@ config BACKLIGHT_SKY81452
>  
>  config BACKLIGHT_TPS65217
>  	tristate "TPS65217 Backlight"
> -	depends on BACKLIGHT_CLASS_DEVICE && MFD_TPS65217
> +	depends on MFD_TPS65217
>  	help
>  	  If you have a Texas Instruments TPS65217 say Y to enable the
>  	  backlight driver.
>  
>  config BACKLIGHT_AS3711
>  	tristate "AS3711 Backlight"
> -	depends on BACKLIGHT_CLASS_DEVICE && MFD_AS3711
> +	depends on MFD_AS3711
>  	help
>  	  If you have an Austrian Microsystems AS3711 say Y to enable the
>  	  backlight driver.
> -- 
> 2.10.2
> 
```

## Re: \[PATCH 1/2\] video: lcd: Remove useless BACKLIGHT\_LCD\_SUPPORT kernel symbol

- From: Daniel Thompson \<hidden\>
- Date: 2018-12-18 17:21:24 
- Message: https://ratatoskr.run/linux-fbdev/2018/12/9152279.md

```text
On Sun, Dec 16, 2018 at 08:02:46AM +0300, Alexander Shiyan wrote:
> Symbol BACKLIGHT_LCD_SUPPORT affecting anything, except enabling
> the backlight & LCD Kconfig menu. The patch removes this symbol as
> useless and converts it into a menu.

Something bothered me about the patch but I think its the lack of
explanation in the patch header about *why* we don't use/need/want
BACKLIGHT_LCD_SUPPORT.

Essentially the reason BACKLIGHT_LCD_SUPPORT is useless is that we have
two _CLASS_DEVICE configs (LCD_CLASS_DEVICE and BACKLIGHT_LCD_DEVICE)
that do the same job (ad that do have code attached to them).

It would be good to mention that in the patch header.


Daniel.

> 
> Signed-off-by: Alexander Shiyan <redacted>
> ---
>  arch/unicore32/Kconfig            |  1 -
>  drivers/gpu/drm/Kconfig           |  2 --
>  drivers/gpu/drm/bridge/Kconfig    |  1 -
>  drivers/gpu/drm/fsl-dcu/Kconfig   |  1 -
>  drivers/gpu/drm/i915/Kconfig      |  1 -
>  drivers/gpu/drm/nouveau/Kconfig   |  1 -
>  drivers/gpu/drm/shmobile/Kconfig  |  1 -
>  drivers/gpu/drm/tilcdc/Kconfig    |  1 -
>  drivers/staging/olpc_dcon/Kconfig |  1 -
>  drivers/usb/misc/Kconfig          |  1 -
>  drivers/video/backlight/Kconfig   | 10 ++--------
>  drivers/video/fbdev/Kconfig       |  5 -----
>  12 files changed, 2 insertions(+), 24 deletions(-)
> 
> diff --git a/arch/unicore32/Kconfig b/arch/unicore32/Kconfig
> index a4c0515..afeea3d 100644
> --- a/arch/unicore32/Kconfig
> +++ b/arch/unicore32/Kconfig
> @@ -211,7 +211,6 @@ config I2C_EEPROM_AT24
>  
>  config LCD_BACKLIGHT
>  	tristate "LCD Backlight support"
> -	select BACKLIGHT_LCD_SUPPORT
>  	select BACKLIGHT_PWM
>  
>  endmenu
> diff --git a/drivers/gpu/drm/Kconfig b/drivers/gpu/drm/Kconfig
> index 4385f00..ef442a7 100644
> --- a/drivers/gpu/drm/Kconfig
> +++ b/drivers/gpu/drm/Kconfig
> @@ -198,7 +198,6 @@ config DRM_RADEON
>  	select POWER_SUPPLY
>  	select HWMON
>  	select BACKLIGHT_CLASS_DEVICE
> -	select BACKLIGHT_LCD_SUPPORT
>  	select INTERVAL_TREE
>  	help
>  	  Choose this option if you have an ATI Radeon graphics card.  There
> @@ -219,7 +218,6 @@ config DRM_AMDGPU
>  	select POWER_SUPPLY
>  	select HWMON
>  	select BACKLIGHT_CLASS_DEVICE
> -	select BACKLIGHT_LCD_SUPPORT
>  	select INTERVAL_TREE
>  	select CHASH
>  	help
> diff --git a/drivers/gpu/drm/bridge/Kconfig b/drivers/gpu/drm/bridge/Kconfig
> index 9eeb8ef..0f724e2 100644
> --- a/drivers/gpu/drm/bridge/Kconfig
> +++ b/drivers/gpu/drm/bridge/Kconfig
> @@ -75,7 +75,6 @@ config DRM_PARADE_PS8622
>  	depends on OF
>  	select DRM_PANEL
>  	select DRM_KMS_HELPER
> -	select BACKLIGHT_LCD_SUPPORT
>  	select BACKLIGHT_CLASS_DEVICE
>  	---help---
>  	  Parade eDP-LVDS bridge chip driver.
> diff --git a/drivers/gpu/drm/fsl-dcu/Kconfig b/drivers/gpu/drm/fsl-dcu/Kconfig
> index 14a72c4..dc82588 100644
> --- a/drivers/gpu/drm/fsl-dcu/Kconfig
> +++ b/drivers/gpu/drm/fsl-dcu/Kconfig
> @@ -2,7 +2,6 @@ config DRM_FSL_DCU
>  	tristate "DRM Support for Freescale DCU"
>  	depends on DRM && OF && ARM && COMMON_CLK
>  	select BACKLIGHT_CLASS_DEVICE
> -	select BACKLIGHT_LCD_SUPPORT
>  	select DRM_KMS_HELPER
>  	select DRM_KMS_CMA_HELPER
>  	select DRM_PANEL
> diff --git a/drivers/gpu/drm/i915/Kconfig b/drivers/gpu/drm/i915/Kconfig
> index 33a458b..90d406e73 100644
> --- a/drivers/gpu/drm/i915/Kconfig
> +++ b/drivers/gpu/drm/i915/Kconfig
> @@ -15,7 +15,6 @@ config DRM_I915
>  	select IRQ_WORK
>  	# i915 depends on ACPI_VIDEO when ACPI is enabled
>  	# but for select to work, need to select ACPI_VIDEO's dependencies, ick
> -	select BACKLIGHT_LCD_SUPPORT if ACPI
>  	select BACKLIGHT_CLASS_DEVICE if ACPI
>  	select INPUT if ACPI
>  	select ACPI_VIDEO if ACPI
> diff --git a/drivers/gpu/drm/nouveau/Kconfig b/drivers/gpu/drm/nouveau/Kconfig
> index 4b75ad40..a0238bf 100644
> --- a/drivers/gpu/drm/nouveau/Kconfig
> +++ b/drivers/gpu/drm/nouveau/Kconfig
> @@ -11,7 +11,6 @@ config DRM_NOUVEAU
>  	select MXM_WMI if ACPI && X86
>  	select POWER_SUPPLY
>  	# Similar to i915, we need to select ACPI_VIDEO and it's dependencies
> -	select BACKLIGHT_LCD_SUPPORT if ACPI && X86
>  	select BACKLIGHT_CLASS_DEVICE if ACPI && X86
>  	select INPUT if ACPI && X86
>  	select THERMAL if ACPI && X86
> diff --git a/drivers/gpu/drm/shmobile/Kconfig b/drivers/gpu/drm/shmobile/Kconfig
> index 61bbe8e..e2a6c82 100644
> --- a/drivers/gpu/drm/shmobile/Kconfig
> +++ b/drivers/gpu/drm/shmobile/Kconfig
> @@ -4,7 +4,6 @@ config DRM_SHMOBILE
>  	depends on DRM && ARM
>  	depends on ARCH_SHMOBILE || COMPILE_TEST
>  	select BACKLIGHT_CLASS_DEVICE
> -	select BACKLIGHT_LCD_SUPPORT
>  	select DRM_KMS_HELPER
>  	select DRM_KMS_CMA_HELPER
>  	select DRM_GEM_CMA_HELPER
> diff --git a/drivers/gpu/drm/tilcdc/Kconfig b/drivers/gpu/drm/tilcdc/Kconfig
> index 5259804..cb7df20 100644
> --- a/drivers/gpu/drm/tilcdc/Kconfig
> +++ b/drivers/gpu/drm/tilcdc/Kconfig
> @@ -8,7 +8,6 @@ config DRM_TILCDC
>  	select DRM_PANEL_BRIDGE
>  	select VIDEOMODE_HELPERS
>  	select BACKLIGHT_CLASS_DEVICE
> -	select BACKLIGHT_LCD_SUPPORT
>  	help
>  	  Choose this option if you have an TI SoC with LCDC display
>  	  controller, for example AM33xx in beagle-bone, DA8xx, or
> diff --git a/drivers/staging/olpc_dcon/Kconfig b/drivers/staging/olpc_dcon/Kconfig
> index 192cc8d..c91a56f 100644
> --- a/drivers/staging/olpc_dcon/Kconfig
> +++ b/drivers/staging/olpc_dcon/Kconfig
> @@ -2,7 +2,6 @@ config FB_OLPC_DCON
>  	tristate "One Laptop Per Child Display CONtroller support"
>  	depends on OLPC && FB
>  	depends on I2C
> -	depends on BACKLIGHT_LCD_SUPPORT
>  	depends on (GPIO_CS5535 || GPIO_CS5535=n)
>  	select BACKLIGHT_CLASS_DEVICE
>  	help
> diff --git a/drivers/usb/misc/Kconfig b/drivers/usb/misc/Kconfig
> index 68d2f2c..a86a80b 100644
> --- a/drivers/usb/misc/Kconfig
> +++ b/drivers/usb/misc/Kconfig
> @@ -141,7 +141,6 @@ config USB_FTDI_ELAN
>  
>  config USB_APPLEDISPLAY
>  	tristate "Apple Cinema Display support"
> -	select BACKLIGHT_LCD_SUPPORT
>  	select BACKLIGHT_CLASS_DEVICE
>  	help
>  	  Say Y here if you want to control the backlight of Apple Cinema
> diff --git a/drivers/video/backlight/Kconfig b/drivers/video/backlight/Kconfig
> index 71ee978..3fdc18e 100644
> --- a/drivers/video/backlight/Kconfig
> +++ b/drivers/video/backlight/Kconfig
> @@ -2,13 +2,7 @@
>  # Backlight & LCD drivers configuration
>  #
>  
> -menuconfig BACKLIGHT_LCD_SUPPORT
> -	bool "Backlight & LCD device support"
> -	help
> -	  Enable this to be able to choose the drivers for controlling the
> -	  backlight and the LCD panel on some platforms, for example on PDAs.
> -
> -if BACKLIGHT_LCD_SUPPORT
> +menu "Backlight & LCD device support"
>  
>  #
>  # LCD
> @@ -466,4 +460,4 @@ config BACKLIGHT_RAVE_SP
>  
>  endif # BACKLIGHT_CLASS_DEVICE
>  
> -endif # BACKLIGHT_LCD_SUPPORT
> +endmenu
> diff --git a/drivers/video/fbdev/Kconfig b/drivers/video/fbdev/Kconfig
> index e413f54..0037d5e 100644
> --- a/drivers/video/fbdev/Kconfig
> +++ b/drivers/video/fbdev/Kconfig
> @@ -186,7 +186,6 @@ config FB_MACMODES
>  config FB_BACKLIGHT
>  	bool
>  	depends on FB
> -	select BACKLIGHT_LCD_SUPPORT
>  	select BACKLIGHT_CLASS_DEVICE
>  
>  config FB_MODE_HELPERS
> @@ -281,7 +280,6 @@ config FB_ARMCLCD
>  	select FB_CFB_IMAGEBLIT
>  	select FB_MODE_HELPERS if OF
>  	select VIDEOMODE_HELPERS if OF
> -	select BACKLIGHT_LCD_SUPPORT if OF
>  	select BACKLIGHT_CLASS_DEVICE if OF
>  	help
>  	  This framebuffer device driver is for the ARM PrimeCell PL110
> @@ -315,7 +313,6 @@ config FB_ACORN
>  config FB_CLPS711X
>  	tristate "CLPS711X LCD support"
>  	depends on FB && (ARCH_CLPS711X || COMPILE_TEST)
> -	select BACKLIGHT_LCD_SUPPORT
>  	select FB_MODE_HELPERS
>  	select FB_SYS_FILLRECT
>  	select FB_SYS_COPYAREA
> @@ -343,7 +340,6 @@ config FB_SA1100
>  config FB_IMX
>  	tristate "Freescale i.MX1/21/25/27 LCD support"
>  	depends on FB && ARCH_MXC
> -	select BACKLIGHT_LCD_SUPPORT
>  	select LCD_CLASS_DEVICE
>  	select FB_CFB_FILLRECT
>  	select FB_CFB_COPYAREA
> @@ -2191,7 +2187,6 @@ config FB_MX3
>  	tristate "MX3 Framebuffer support"
>  	depends on FB && MX3_IPU
>  	select BACKLIGHT_CLASS_DEVICE
> -	select BACKLIGHT_LCD_SUPPORT
>  	select FB_CFB_FILLRECT
>  	select FB_CFB_COPYAREA
>  	select FB_CFB_IMAGEBLIT
> -- 
> 2.10.2
> 
```
