# \[PATCH\] video/backlight: Use of\_node\_name\_eq for node name comparisons - Subsystems: FRAMEBUFFER LAYER, BACKLIGHT CLASS/SUBSYSTEM, THE REST - Maintainers: Helge Deller, Lee Jones, Daniel Thompson, Jingoo Han, Linus Torvalds - List: linux-fbdev - 3 messages, 3 authors - Page: https://ratatoskr.run/linux-fbdev/2018/12/5454423/t ## \[PATCH\] video/backlight: Use of\_node\_name\_eq for node name comparisons - From: Rob Herring \ - Date: 2018-12-05 19:52:03 - Message: https://ratatoskr.run/linux-fbdev/2018/12/5454423.md ```text Convert string compares of DT node names to use of_node_name_eq helper instead. This removes direct access to the node name pointer. For instances using of_node_cmp, this has the side effect of now using case sensitive comparisons. This should not matter for any FDT based system which this is. Cc: Lee Jones Cc: Daniel Thompson Cc: Jingoo Han Cc: Bartlomiej Zolnierkiewicz Cc: Cc: Signed-off-by: Rob Herring --- drivers/video/backlight/88pm860x_bl.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/video/backlight/88pm860x_bl.c b/drivers/video/backlight/88pm860x_bl.c index 6d8dc2c77520..51e0c4be08df 100644 --- a/drivers/video/backlight/88pm860x_bl.c +++ b/drivers/video/backlight/88pm860x_bl.c @@ -174,7 +174,7 @@ static int pm860x_backlight_dt_init(struct platform_device *pdev, return -ENODEV; } for_each_child_of_node(nproot, np) { - if (!of_node_cmp(np->name, name)) { + if (of_node_name_eq(np, name)) { of_property_read_u32(np, "marvell,88pm860x-iset", &iset); data->iset = PM8606_WLED_CURRENT(iset); -- 2.19.1 ``` ## Re: \[PATCH\] video/backlight: Use of\_node\_name\_eq for node name comparisons - From: Daniel Thompson \ - Date: 2018-12-06 14:02:31 - Message: https://ratatoskr.run/linux-fbdev/2018/12/5455239.md ```text On Wed, Dec 05, 2018 at 01:50:44PM -0600, Rob Herring wrote: > Convert string compares of DT node names to use of_node_name_eq helper > instead. This removes direct access to the node name pointer. > > For instances using of_node_cmp, this has the side effect of now using > case sensitive comparisons. This should not matter for any FDT based > system which this is. > > Cc: Lee Jones > Cc: Daniel Thompson > Cc: Jingoo Han > Cc: Bartlomiej Zolnierkiewicz > Cc: > Cc: > Signed-off-by: Rob Herring Acked-by: Daniel Thompson [this is FAO Lee J. rather than recommending you take it via you tree] > --- > drivers/video/backlight/88pm860x_bl.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/video/backlight/88pm860x_bl.c b/drivers/video/backlight/88pm860x_bl.c > index 6d8dc2c77520..51e0c4be08df 100644 > --- a/drivers/video/backlight/88pm860x_bl.c > +++ b/drivers/video/backlight/88pm860x_bl.c > @@ -174,7 +174,7 @@ static int pm860x_backlight_dt_init(struct platform_device *pdev, > return -ENODEV; > } > for_each_child_of_node(nproot, np) { > - if (!of_node_cmp(np->name, name)) { > + if (of_node_name_eq(np, name)) { > of_property_read_u32(np, "marvell,88pm860x-iset", > &iset); > data->iset = PM8606_WLED_CURRENT(iset); > -- > 2.19.1 > ``` ## Re: \[PATCH\] video/backlight: Use of\_node\_name\_eq for node name comparisons - From: Lee Jones \ - Date: 2018-12-14 12:27:17 - Message: https://ratatoskr.run/linux-fbdev/2018/12/5463599.md ```text On Thu, 06 Dec 2018, Daniel Thompson wrote: > On Wed, Dec 05, 2018 at 01:50:44PM -0600, Rob Herring wrote: > > Convert string compares of DT node names to use of_node_name_eq helper > > instead. This removes direct access to the node name pointer. > > > > For instances using of_node_cmp, this has the side effect of now using > > case sensitive comparisons. This should not matter for any FDT based > > system which this is. > > > > Cc: Lee Jones > > Cc: Daniel Thompson > > Cc: Jingoo Han > > Cc: Bartlomiej Zolnierkiewicz > > Cc: > > Cc: > > Signed-off-by: Rob Herring > > Acked-by: Daniel Thompson > > [this is FAO Lee J. rather than recommending you take it via you tree] Rob knows better than that. ;) Applied, thanks. -- Lee Jones [李琼斯] Linaro Services Technical Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog ```