# \[PATCH\] fbdev: fsl-diu: remove redundant null check on cmap

- Subsystems: FRAMEBUFFER LAYER, FREESCALE DIU FRAMEBUFFER DRIVER, THE REST
- Maintainers: Helge Deller, Timur Tabi, Linus Torvalds
- List: linux-fbdev
- 3 messages, 3 authors
- Page: https://ratatoskr.run/linux-fbdev/2018/12/5450515/t

## \[PATCH\] fbdev: fsl-diu: remove redundant null check on cmap

- From: Wen Yang \<hidden\>
- Date: 2018-12-03 06:43:30 
- Message: https://ratatoskr.run/linux-fbdev/2018/12/5450515.md

```text
The null check on &info->cmap is redundant since cmap is a struct
inside fb_info and can never be null, so the check is always true.
we may remove it.

Signed-off-by: Wen Yang <redacted>
CC: Timur Tabi <timur@kernel.org>
CC: Bartlomiej Zolnierkiewicz <redacted>
CC: <redacted>
CC: <redacted>
CC: <redacted>
---
 drivers/video/fbdev/fsl-diu-fb.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/video/fbdev/fsl-diu-fb.c b/drivers/video/fbdev/fsl-diu-fb.c
index 332a56b6811f..9a5451ba4d44 100644
--- a/drivers/video/fbdev/fsl-diu-fb.c
+++ b/drivers/video/fbdev/fsl-diu-fb.c
@@ -1575,8 +1575,7 @@ static void uninstall_fb(struct fb_info *info)
 
 	unregister_framebuffer(info);
 	unmap_video_memory(info);
-	if (&info->cmap)
-		fb_dealloc_cmap(&info->cmap);
+	fb_dealloc_cmap(&info->cmap);
 
 	mfbi->registered = 0;
 }
-- 
2.19.1
```

## Re: \[PATCH\] fbdev: fsl-diu: remove redundant null check on cmap

- From: Timur Tabi \<timur@kernel.org\>
- Date: 2018-12-03 14:53:57 
- Message: https://ratatoskr.run/linux-fbdev/2018/12/5451045.md

```text
On 12/3/18 12:43 AM, Wen Yang wrote:
> The null check on &info->cmap is redundant since cmap is a struct
> inside fb_info and can never be null, so the check is always true.
> we may remove it.
> 
> Signed-off-by: Wen Yang<redacted>

Acked-by: Timur Tabi <timur@kernel.org>
```

## Re: \[PATCH\] fbdev: fsl-diu: remove redundant null check on cmap

- From: Bartlomiej Zolnierkiewicz \<hidden\>
- Date: 2018-12-20 17:58:55 
- Message: https://ratatoskr.run/linux-fbdev/2018/12/5468877.md

```text

On 12/03/2018 03:53 PM, Timur Tabi wrote:
> On 12/3/18 12:43 AM, Wen Yang wrote:
>> The null check on &info->cmap is redundant since cmap is a struct
>> inside fb_info and can never be null, so the check is always true.
>> we may remove it.
>>
>> Signed-off-by: Wen Yang<redacted>
> 
> Acked-by: Timur Tabi <timur@kernel.org>

Patch queued for 4.21, thanks.

Best regards,
--
Bartlomiej Zolnierkiewicz
Samsung R&D Institute Poland
Samsung Electronics
```