# \[PATCH v2 -next\] video: fbdev: pxafb: Fix "WARNING: invalid free of devm\_ allocated data"

- Subsystems: FRAMEBUFFER LAYER, THE REST
- Maintainers: Helge Deller, Linus Torvalds
- Status: REVIEWED · 1 review, 1 by a maintainer (M Daniel Mack)
- Reviewed.
- 1 review trailer.
- List: linux-fbdev
- 2 messages, 2 authors
- Page: https://ratatoskr.run/linux-fbdev/2018/11/5436834/t

## \[PATCH v2 -next\] video: fbdev: pxafb: Fix "WARNING: invalid free of devm\_ allocated data"

- From: YueHaibing \<hidden\>
- Date: 2018-11-19 01:36:55 
- Message: https://ratatoskr.run/linux-fbdev/2018/11/5436834.md

```text
'info->modes' got allocated with devm_kcalloc in of_get_pxafb_display.

This gives this error message:
  ./drivers/video/fbdev/pxafb.c:2238:2-7: WARNING: invalid free of devm_ allocated data

Fixes: c8f96304ec8b4 ("video: fbdev: pxafb: switch to devm_* API")
Cc: stable@kernel.org [v4.19+]
Signed-off-by: YueHaibing <redacted>
Reviewed-by: Daniel Mack <daniel@zonque.org>
---
 drivers/video/fbdev/pxafb.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/drivers/video/fbdev/pxafb.c b/drivers/video/fbdev/pxafb.c
index bbed039..d59c8a5 100644
--- a/drivers/video/fbdev/pxafb.c
+++ b/drivers/video/fbdev/pxafb.c
@@ -2234,10 +2234,8 @@ static struct pxafb_mach_info *of_pxafb_of_mach_info(struct device *dev)
 	if (!info)
 		return ERR_PTR(-ENOMEM);
 	ret = of_get_pxafb_mode_info(dev, info);
-	if (ret) {
-		kfree(info->modes);
+	if (ret)
 		return ERR_PTR(ret);
-	}
 
 	/*
 	 * On purpose, neither lccrX registers nor video memory size can be
-- 
2.7.0
```

## Re: \[PATCH v2 -next\] video: fbdev: pxafb: Fix "WARNING: invalid free of devm\_ allocated data"

- From: Bartlomiej Zolnierkiewicz \<hidden\>
- Date: 2018-12-20 16:57:49 
- Message: https://ratatoskr.run/linux-fbdev/2018/12/5468793.md

```text

On 11/19/2018 02:36 AM, YueHaibing wrote:
> 'info->modes' got allocated with devm_kcalloc in of_get_pxafb_display.
> 
> This gives this error message:
>   ./drivers/video/fbdev/pxafb.c:2238:2-7: WARNING: invalid free of devm_ allocated data
> 
> Fixes: c8f96304ec8b4 ("video: fbdev: pxafb: switch to devm_* API")
> Cc: stable@kernel.org [v4.19+]
> Signed-off-by: YueHaibing <redacted>
> Reviewed-by: Daniel Mack <daniel@zonque.org>

Patch queued for 4.21, thanks.

Best regards,
--
Bartlomiej Zolnierkiewicz
Samsung R&D Institute Poland
Samsung Electronics
```