# Re: \[PATCH 1/3\] mach64: fix display corruption on big endian machines

- From: Bartlomiej Zolnierkiewicz \<hidden\>
- Date: 2018-10-08 10:36:22 
- List: linux-fbdev
- Page: https://ratatoskr.run/linux-fbdev/2018/10/9147416
- Thread: https://ratatoskr.run/linux-fbdev/2018/08/9144395/t.md

```text

On 08/27/2018 02:54 PM, Ville Syrj채l채 wrote:
> On Sat, Aug 25, 2018 at 03:51:00PM -0400, Mikulas Patocka wrote:
>> The code for manual bit triple is not endian-clean. It builds the variable
>> "hostdword" using byte accesses, therefore we must read the variable with
>> "le32_to_cpu".
>>
>> The patch also enables (hardware or software) bit triple only if the image
>> is monochrome (image->depth). If we want to blit full-color image, we
>> shouldn't use the triple code.
> 
> Makes sense.
> Reviewed-by: Ville Syrj채l채 <syrjala@sci.fi>

Patch queued for 4.20, thanks.

Best regards,
--
Bartlomiej Zolnierkiewicz
Samsung R&D Institute Poland
Samsung Electronics
```