# \[PATCH\] video: fbdev: arcfb: mark expected switch fall-through

- Subsystems: FRAMEBUFFER LAYER, ARC FRAMEBUFFER DRIVER, THE REST
- Maintainers: Helge Deller, Jaya Kumar, Linus Torvalds
- List: linux-fbdev
- 2 messages, 2 authors
- Page: https://ratatoskr.run/linux-fbdev/2018/10/5398281/t

## \[PATCH\] video: fbdev: arcfb: mark expected switch fall-through

- From: Gustavo A. R. Silva \<hidden\>
- Date: 2018-10-03 12:14:55 
- Message: https://ratatoskr.run/linux-fbdev/2018/10/5398281.md

```text
In preparation to enabling -Wimplicit-fallthrough, mark switch cases
where we are expecting to fall through.

Addresses-Coverity-ID: 115017 ("Missing break in switch")
Signed-off-by: Gustavo A. R. Silva <redacted>
---
 drivers/video/fbdev/arcfb.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/drivers/video/fbdev/arcfb.c b/drivers/video/fbdev/arcfb.c
index 7e87d0d..a48741a 100644
--- a/drivers/video/fbdev/arcfb.c
+++ b/drivers/video/fbdev/arcfb.c
@@ -419,6 +419,8 @@ static int arcfb_ioctl(struct fb_info *info,
 			schedule();
 			finish_wait(&arcfb_waitq, &wait);
 		}
+		/* fall through */
+
 		case FBIO_GETCONTROL2:
 		{
 			unsigned char ctl2;
-- 
2.7.4
```

## Re: \[PATCH\] video: fbdev: arcfb: mark expected switch fall-through

- From: Bartlomiej Zolnierkiewicz \<hidden\>
- Date: 2018-10-08 10:54:56 
- Message: https://ratatoskr.run/linux-fbdev/2018/10/5401633.md

```text

On 10/03/2018 01:50 PM, Gustavo A. R. Silva wrote:
> In preparation to enabling -Wimplicit-fallthrough, mark switch cases
> where we are expecting to fall through.
> 
> Addresses-Coverity-ID: 115017 ("Missing break in switch")
> Signed-off-by: Gustavo A. R. Silva <redacted>

Patch queued for 4.20, thanks.

Best regards,
--
Bartlomiej Zolnierkiewicz
Samsung R&D Institute Poland
Samsung Electronics
```