# \[PATCH\] staging: sm750fb: Replace CamelCase variable names with underscores

- From: Aleksa Zdravkovic \<hidden\>
- Date: 2018-10-23 20:35:12 
- List: linux-fbdev
- Page: https://ratatoskr.run/linux-fbdev/2018/10/13466902
- Thread: https://ratatoskr.run/linux-fbdev/2018/10/13466902/t.md

```text
Change variable names devId and revId to dev_id and rev_id
to meet linux kernel coding style. Issue found by checkpatch.

Signed-off-by: Aleksa Zdravkovic <redacted>
---
 drivers/staging/sm750fb/ddk750_chip.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/drivers/staging/sm750fb/ddk750_chip.c b/drivers/staging/sm750fb/ddk750_chip.c
index 4c1f00f551da..6bdf643707c2 100644
--- a/drivers/staging/sm750fb/ddk750_chip.c
+++ b/drivers/staging/sm750fb/ddk750_chip.c
@@ -15,14 +15,14 @@ enum logical_chip_type sm750_get_chip_type(void)
 	return chip;
 }
 
-void sm750_set_chip_type(unsigned short devId, u8 revId)
+void sm750_set_chip_type(unsigned short dev_id, u8 rev_id)
 {
-	if (devId = 0x718) {
+	if (dev_id = 0x718) {
 		chip = SM718;
-	} else if (devId = 0x750) {
+	} else if (dev_id = 0x750) {
 		chip = SM750;
 		/* SM750 and SM750LE are different in their revision ID only. */
-		if (revId = SM750LE_REVISION_ID) {
+		if (rev_id = SM750LE_REVISION_ID) {
 			chip = SM750LE;
 			pr_info("found sm750le\n");
 		}
-- 
2.19.1
```