# Re: \[PATCH v3 03/13\] fbdev: add kerneldoc do remove\_conflicting\_framebuffers()

- From: Paul Menzel \<hidden\>
- Date: 2018-09-05 11:02:32 
- List: linux-fbdev
- Page: https://ratatoskr.run/linux-fbdev/2018/09/8772557
- Thread: https://ratatoskr.run/linux-arm-kernel/2018/08/8772452/t.md

```text
Dear Michał,


Thank you for documenting the function. Do you mean *to* instead of *do*
in the commit message summary?


On 09/01/18 16:08, Michał Mirosław wrote:
> Document remove_conflicting_framebuffers() behaviour.
> 
> Signed-off-by: Michał Mirosław <mirq-linux@rere.qmqm.pl>
> ---
>  drivers/video/fbdev/core/fbmem.c | 10 ++++++++++
>  1 file changed, 10 insertions(+)
> 
> diff --git a/drivers/video/fbdev/core/fbmem.c b/drivers/video/fbdev/core/fbmem.c
> index 0df148eb4699..2de93b5014e3 100644
> --- a/drivers/video/fbdev/core/fbmem.c
> +++ b/drivers/video/fbdev/core/fbmem.c
> @@ -1775,6 +1775,16 @@ int unlink_framebuffer(struct fb_info *fb_info)
>  }
>  EXPORT_SYMBOL(unlink_framebuffer);
>  
> +/**
> + * remove_conflicting_framebuffers - remove firmware-configured framebuffers
> + * @a: memory range, users of which are to be removed
> + * @name: requesting driver name
> + * @primary: also kick vga16fb if present
> + *
> + * This function removes framebuffer devices (initialized by firmware/bootloader)
> + * which use memory range described by @a. If @a is NULL all such devices are
> + * removed.
> + */
>  int remove_conflicting_framebuffers(struct apertures_struct *a,
>  				    const char *name, bool primary)
>  {

Acked-by: Paul Menzel <redacted>


Kind regards,

Paul

```

## Attachments

- [smime.p7s](https://ratatoskr.run/linux-fbdev/2018/09/8772557/attachment/0) (application/pkcs7-signature, 5174 bytes)