# Re: \[PATCH v2 3/3\] drivers/block/z2ram: use ioremap\_wt() instead of \_\_ioremap(\_PAGE\_WRITETHRU)

- From: Geert Uytterhoeven \<geert@linux-m68k.org\>
- Date: 2018-08-27 16:42:32 
- List: linux-fbdev
- Page: https://ratatoskr.run/linux-fbdev/2018/08/5364669
- Thread: https://ratatoskr.run/linuxppc-dev/2018/08/5364650/t.md

```text
On Mon, Aug 27, 2018 at 6:10 PM Christophe Leroy
[ref] wrote:
> _PAGE_WRITETHRU is a target specific flag. Prefer generic functions.
>
> Signed-off-by: Christophe Leroy <redacted>

From a Zorro bus point of view:
Acked-by: Geert Uytterhoeven <geert@linux-m68k.org>

> --- a/drivers/block/z2ram.c
> +++ b/drivers/block/z2ram.c
> @@ -190,8 +190,7 @@ static int z2_open(struct block_device *bdev, fmode_t mode)
>                         vfree(vmalloc (size));
>                 }
>
> -               vaddr = (unsigned long) __ioremap (paddr, size,
> -                                                  _PAGE_WRITETHRU);
> +               vaddr = (unsigned long)ioremap_wt(paddr, size);
>
>  #else
>                 vaddr = (unsigned long)z_remap_nocache_nonser(paddr, size);

However, since the removal of APUS support, this file can no longer be
compiled on powerpc.

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds
```