# \[PATCH\] ddk750\_mode.c: Wraps line to 80 charecters

- Subsystems: STAGING - SILICON MOTION SM750 FRAME BUFFER DRIVER, STAGING SUBSYSTEM, THE REST
- Maintainers: Sudip Mukherjee, Teddy Wang, Sudip Mukherjee, Greg Kroah-Hartman, Linus Torvalds
- List: linux-fbdev
- 3 messages, 2 authors
- Page: https://ratatoskr.run/linux-fbdev/2018/08/5353329/t

## \[PATCH\] ddk750\_mode.c: Wraps line to 80 charecters

- From: Abishek V Ashok \<hidden\>
- Date: 2018-08-08 09:36:17 
- Message: https://ratatoskr.run/linux-fbdev/2018/08/5353329.md

```text
Splits definition of function programModeRegisters into two lines such
that each line is less than 80 characters.

Signed-off-by: Abishek V Ashok <redacted>
---
 drivers/staging/sm750fb/ddk750_mode.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/staging/sm750fb/ddk750_mode.c b/drivers/staging/sm750fb/ddk750_mode.c
index 7e22d093b..57cf9e6a5 100644
--- a/drivers/staging/sm750fb/ddk750_mode.c
+++ b/drivers/staging/sm750fb/ddk750_mode.c
@@ -13,8 +13,8 @@
  * HW only supports 7 predefined pixel clocks, and clock select is
  * in bit 29:27 of Display Control register.
  */
-static unsigned long displayControlAdjust_SM750LE(struct mode_parameter *pModeParam,
-						  unsigned long dispControl)
+static unsigned long displayControlAdjust_SM750LE(
+		struct mode_parameter *pModeParam, unsigned long dispControl)
 {
 	unsigned long x, y;
 
-- 
2.18.0

```

## Re: \[PATCH\] ddk750\_mode.c: Wraps line to 80 charecters

- From: Greg KH \<gregkh@linuxfoundation.org\>
- Date: 2018-08-27 18:08:47 
- Message: https://ratatoskr.run/linux-fbdev/2018/08/5364711.md

```text
On Wed, Aug 08, 2018 at 03:05:52PM +0530, Abishek V Ashok wrote:
> Splits definition of function programModeRegisters into two lines such
> that each line is less than 80 characters.
> 
> Signed-off-by: Abishek V Ashok <redacted>
> ---
>  drivers/staging/sm750fb/ddk750_mode.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 

Please put the subsystem in the subject line to make it harder to miss
your patch, you need a "staging:" in there, like all other patches for
drivers/staging/

Please fix up and resend.


thanks,

greg k-h
```

## Re: \[PATCH\] ddk750\_mode.c: Wraps line to 80 charecters

- From: Greg KH \<gregkh@linuxfoundation.org\>
- Date: 2018-08-27 18:08:52 
- Message: https://ratatoskr.run/linux-fbdev/2018/08/5364712.md

```text
On Wed, Aug 08, 2018 at 03:05:52PM +0530, Abishek V Ashok wrote:
> Splits definition of function programModeRegisters into two lines such
> that each line is less than 80 characters.
> 
> Signed-off-by: Abishek V Ashok <redacted>
> ---
>  drivers/staging/sm750fb/ddk750_mode.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/staging/sm750fb/ddk750_mode.c b/drivers/staging/sm750fb/ddk750_mode.c
> index 7e22d093b..57cf9e6a5 100644
> --- a/drivers/staging/sm750fb/ddk750_mode.c
> +++ b/drivers/staging/sm750fb/ddk750_mode.c
> @@ -13,8 +13,8 @@
>   * HW only supports 7 predefined pixel clocks, and clock select is
>   * in bit 29:27 of Display Control register.
>   */
> -static unsigned long displayControlAdjust_SM750LE(struct mode_parameter *pModeParam,
> -						  unsigned long dispControl)
> +static unsigned long displayControlAdjust_SM750LE(
> +		struct mode_parameter *pModeParam, unsigned long dispControl)

Ick, actually the original code is just fine here, please leave it
as-is.

thanks,,

greg k-h
```