# Re: \[PATCH v2 1/2\] efi/bgrt: Drop \_\_initdata from bgrt\_image\_size

- From: Hans de Goede \<hidden\>
- Date: 2018-07-02 11:26:06 
- List: linux-fbdev
- Page: https://ratatoskr.run/linux-fbdev/2018/07/9141268
- Thread: https://ratatoskr.run/linux-fbdev/2018/06/9140459/t.md

```text
Bartlomiej,

Now that the fbcon deferred console takeover patches have been
merged I believe this series can be merged too ?

Note the first patch has an ack from Ard for merging the
1 line efi change through the fbdev tree.

Regards,

Hans


On 18-06-18 17:13, Hans de Goede wrote:
> bgrt_image_size is necessary to (optionally) show the boot graphics from
> the efifb code. The efifb driver is a platform driver, using a normal
> driver probe() driver callback. So even though it is always builtin it
> cannot reference __initdata.
> 
> Acked-by: Ard Biesheuvel <redacted>
> Signed-off-by: Hans de Goede <redacted>
> ---
>   drivers/firmware/efi/efi-bgrt.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/firmware/efi/efi-bgrt.c b/drivers/firmware/efi/efi-bgrt.c
> index 50793fda7819..b22ccfb0c991 100644
> --- a/drivers/firmware/efi/efi-bgrt.c
> +++ b/drivers/firmware/efi/efi-bgrt.c
> @@ -20,7 +20,7 @@
>   #include <linux/efi-bgrt.h>
>   
>   struct acpi_table_bgrt bgrt_tab;
> -size_t __initdata bgrt_image_size;
> +size_t bgrt_image_size;
>   
>   struct bmp_header {
>   	u16 id;
> 
```
