# \[PATCH\] video: fbdev: via: hide unused procfs helpers

- Subsystems: FRAMEBUFFER LAYER, VIA UNICHROME(PRO)/CHROME9 FRAMEBUFFER DRIVER, THE REST
- Maintainers: Helge Deller, Florian Tobias Schandinat, Linus Torvalds
- List: linux-fbdev
- 2 messages, 1 author
- Page: https://ratatoskr.run/linux-fbdev/2018/07/5331801/t

## \[PATCH\] video: fbdev: via: hide unused procfs helpers

- From: YueHaibing \<hidden\>
- Date: 2018-07-13 07:57:25 
- Message: https://ratatoskr.run/linux-fbdev/2018/07/5331801.md

```text
When CONFIG_PROC_FS isn't set, gcc warning this:

drivers/video/fbdev/via/viafbdev.c:1471:12: warning: ‘viafb_sup_odev_proc_show’ defined but not used [-Wunused-function]
 static int viafb_sup_odev_proc_show(struct seq_file *m, void *v)
            ^
fix this by adding #ifdef around it.

Signed-off-by: YueHaibing <redacted>
---
 drivers/video/fbdev/via/viafbdev.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/drivers/video/fbdev/via/viafbdev.c b/drivers/video/fbdev/via/viafbdev.c
index d2f7850..edca3e0 100644
--- a/drivers/video/fbdev/via/viafbdev.c
+++ b/drivers/video/fbdev/via/viafbdev.c
@@ -1468,12 +1468,14 @@ static const struct file_operations viafb_vt1636_proc_fops = {
 
 #endif /* CONFIG_FB_VIA_DIRECT_PROCFS */
 
+#ifdef CONFIG_PROC_FS
 static int viafb_sup_odev_proc_show(struct seq_file *m, void *v)
 {
 	via_odev_to_seq(m, supported_odev_map[
 		viaparinfo->shared->chip_info.gfx_chip_name]);
 	return 0;
 }
+#endif
 
 static ssize_t odev_update(const char __user *buffer, size_t count, u32 *odev)
 {
-- 
2.7.0


```

## Re: \[PATCH\] video: fbdev: via: hide unused procfs helpers

- From: YueHaibing \<hidden\>
- Date: 2018-07-13 09:41:42 
- Message: https://ratatoskr.run/linux-fbdev/2018/07/5331887.md

```text
Pls ignore this.there has a fix:

[PATCH] fbdev/via: fix defined but not used warning

On 2018/7/13 15:56, YueHaibing wrote:
> When CONFIG_PROC_FS isn't set, gcc warning this:
> 
> drivers/video/fbdev/via/viafbdev.c:1471:12: warning: ‘viafb_sup_odev_proc_show’ defined but not used [-Wunused-function]
>  static int viafb_sup_odev_proc_show(struct seq_file *m, void *v)
>             ^
> fix this by adding #ifdef around it.
> 
> Signed-off-by: YueHaibing <redacted>
> ---
>  drivers/video/fbdev/via/viafbdev.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/drivers/video/fbdev/via/viafbdev.c b/drivers/video/fbdev/via/viafbdev.c
> index d2f7850..edca3e0 100644
> --- a/drivers/video/fbdev/via/viafbdev.c
> +++ b/drivers/video/fbdev/via/viafbdev.c
> @@ -1468,12 +1468,14 @@ static const struct file_operations viafb_vt1636_proc_fops = {
>  
>  #endif /* CONFIG_FB_VIA_DIRECT_PROCFS */
>  
> +#ifdef CONFIG_PROC_FS
>  static int viafb_sup_odev_proc_show(struct seq_file *m, void *v)
>  {
>  	via_odev_to_seq(m, supported_odev_map[
>  		viaparinfo->shared->chip_info.gfx_chip_name]);
>  	return 0;
>  }
> +#endif
>  
>  static ssize_t odev_update(const char __user *buffer, size_t count, u32 *odev)
>  {
> 

```