Re: [PATCH v5 2/3] fbcon: Call WARN_CONSOLE_UNLOCKED() where applicable
From: Steven Rostedt <rostedt@goodmis.org>
Date: 2018-07-11 19:19:16
Also in:
dri-devel, lkml
From: Steven Rostedt <rostedt@goodmis.org>
Date: 2018-07-11 19:19:16
Also in:
dri-devel, lkml
On Wed, 11 Jul 2018 19:56:02 +0200 Daniel Vetter [off-list ref] wrote:
quoted
Have you seen Steven's suggestion which he send about the same time as your mail I'm replying to here ? I personally think that doing something like that makes sense (for as long as we have the need for the lockless_fb_register debug hack). Note I've 2 patches ready to go to only fix this in fbcon.c, but I think a more thorough fix makes sense.Yeah Steven's suggestion looks reasonable to fix this all for good. The #if 1 predates git history, so no idea why it was added or by whom :-)
I just sent the patch. If the printk maintainers take it, then you can update the fb driver to set the ignore_console_lock_warning when lockless_fb_register is set. -- Steve