# \[PATCH\] backlight: adp8860: Mark expected switch fall-through - Subsystems: FRAMEBUFFER LAYER, ADP8860 BACKLIGHT DRIVER (ADP8860/ADP8861/ADP8863), BACKLIGHT CLASS/SUBSYSTEM, THE REST - Maintainers: Helge Deller, Michael Hennerich, Lee Jones, Daniel Thompson, Jingoo Han, Linus Torvalds - List: linux-fbdev - 5 messages, 4 authors - Page: https://ratatoskr.run/linux-fbdev/2018/07/5328343/t ## \[PATCH\] backlight: adp8860: Mark expected switch fall-through - From: Gustavo A. R. Silva \ - Date: 2018-07-09 21:52:04 - Message: https://ratatoskr.run/linux-fbdev/2018/07/5328343.md ```text In preparation to enabling -Wimplicit-fallthrough, mark switch cases where we are expecting to fall through. Signed-off-by: Gustavo A. R. Silva --- drivers/video/backlight/adp8860_bl.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/video/backlight/adp8860_bl.c b/drivers/video/backlight/adp8860_bl.c index 16119bd..f1dc41c 100644 --- a/drivers/video/backlight/adp8860_bl.c +++ b/drivers/video/backlight/adp8860_bl.c @@ -690,6 +690,7 @@ static int adp8860_probe(struct i2c_client *client, switch (ADP8860_MANID(reg_val)) { case ADP8863_MANUFID: data->gdwn_dis = !!pdata->gdwn_dis; + /* fall through */ case ADP8860_MANUFID: data->en_ambl_sens = !!pdata->en_ambl_sens; break; -- 2.7.4 ``` ## Re: \[PATCH\] backlight: adp8860: Mark expected switch fall-through - From: Lee Jones \ - Date: 2018-07-10 05:24:46 - Message: https://ratatoskr.run/linux-fbdev/2018/07/5328540.md ```text On Mon, 09 Jul 2018, Gustavo A. R. Silva wrote: > In preparation to enabling -Wimplicit-fallthrough, mark switch cases > where we are expecting to fall through. > > Signed-off-by: Gustavo A. R. Silva > --- > drivers/video/backlight/adp8860_bl.c | 1 + > 1 file changed, 1 insertion(+) Looks good to me, but Dan should still review. https://gcc.gnu.org/onlinedocs/gcc-8.1.0/gcc.pdf#page† Acked-by: Lee Jones -- Lee Jones [æ��ç�¼æ–¯] Linaro Services Technical Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog -- To unsubscribe from this list: send the line "unsubscribe linux-fbdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html ``` ## Re: \[PATCH\] backlight: adp8860: Mark expected switch fall-through - From: Michael Hennerich \ - Date: 2018-07-10 06:42:54 - Message: https://ratatoskr.run/linux-fbdev/2018/07/5328575.md ```text On 09.07.2018 23:51, Gustavo A. R. Silva wrote: > In preparation to enabling -Wimplicit-fallthrough, mark switch cases > where we are expecting to fall through. > > Signed-off-by: Gustavo A. R. Silva Acked-by: Michael Hennerich > --- > drivers/video/backlight/adp8860_bl.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/video/backlight/adp8860_bl.c b/drivers/video/backlight/adp8860_bl.c > index 16119bd..f1dc41c 100644 > --- a/drivers/video/backlight/adp8860_bl.c > +++ b/drivers/video/backlight/adp8860_bl.c > @@ -690,6 +690,7 @@ static int adp8860_probe(struct i2c_client *client, > switch (ADP8860_MANID(reg_val)) { > case ADP8863_MANUFID: > data->gdwn_dis = !!pdata->gdwn_dis; > + /* fall through */ > case ADP8860_MANUFID: > data->en_ambl_sens = !!pdata->en_ambl_sens; > break; > -- Greetings, Michael -- Analog Devices GmbH Otl-Aicher Strasse 60-64 80807 München Sitz der Gesellschaft München, Registergericht München HRB 40368, Geschäftsführer: Peter Kolberg, Ali Raza Husain, Eileen Wynne ``` ## Re: \[PATCH\] backlight: adp8860: Mark expected switch fall-through - From: Daniel Thompson \ - Date: 2018-07-10 09:00:14 - Message: https://ratatoskr.run/linux-fbdev/2018/07/5328693.md ```text On Mon, Jul 09, 2018 at 04:51:56PM -0500, Gustavo A. R. Silva wrote: > In preparation to enabling -Wimplicit-fallthrough, mark switch cases > where we are expecting to fall through. > > Signed-off-by: Gustavo A. R. Silva Having checked the datasheets... Reviewed-by: Daniel Thompson > --- > drivers/video/backlight/adp8860_bl.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/video/backlight/adp8860_bl.c b/drivers/video/backlight/adp8860_bl.c > index 16119bd..f1dc41c 100644 > --- a/drivers/video/backlight/adp8860_bl.c > +++ b/drivers/video/backlight/adp8860_bl.c > @@ -690,6 +690,7 @@ static int adp8860_probe(struct i2c_client *client, > switch (ADP8860_MANID(reg_val)) { > case ADP8863_MANUFID: > data->gdwn_dis = !!pdata->gdwn_dis; > + /* fall through */ > case ADP8860_MANUFID: > data->en_ambl_sens = !!pdata->en_ambl_sens; > break; > -- > 2.7.4 > ``` ## Re: \[PATCH\] backlight: adp8860: Mark expected switch fall-through - From: Lee Jones \ - Date: 2018-07-13 07:35:32 - Message: https://ratatoskr.run/linux-fbdev/2018/07/5331780.md ```text On Mon, 09 Jul 2018, Gustavo A. R. Silva wrote: > In preparation to enabling -Wimplicit-fallthrough, mark switch cases > where we are expecting to fall through. > > Signed-off-by: Gustavo A. R. Silva > --- > drivers/video/backlight/adp8860_bl.c | 1 + > 1 file changed, 1 insertion(+) Applied, thanks. -- Lee Jones [李琼斯] Linaro Services Technical Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog ```