# \[PATCH\] fbdev: fbmem: mark expected switch fall-through

- Subsystems: FRAMEBUFFER LAYER, FRAMEBUFFER CORE, THE REST
- Maintainers: Helge Deller, Simona Vetter, Linus Torvalds
- List: linux-fbdev
- 2 messages, 2 authors
- Page: https://ratatoskr.run/linux-fbdev/2018/07/5328329/t

## \[PATCH\] fbdev: fbmem: mark expected switch fall-through

- From: Gustavo A. R. Silva \<hidden\>
- Date: 2018-07-09 21:36:52 
- Message: https://ratatoskr.run/linux-fbdev/2018/07/5328329.md

```text
In preparation to enabling -Wimplicit-fallthrough, mark switch cases
where we are expecting to fall through.

Signed-off-by: Gustavo A. R. Silva <redacted>
---
 drivers/video/fbdev/core/fbmem.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/video/fbdev/core/fbmem.c b/drivers/video/fbdev/core/fbmem.c
index 609438d..5f3133b 100644
--- a/drivers/video/fbdev/core/fbmem.c
+++ b/drivers/video/fbdev/core/fbmem.c
@@ -1347,6 +1347,7 @@ static long fb_compat_ioctl(struct file *file, unsigned int cmd,
 	case FBIOGET_CON2FBMAP:
 	case FBIOPUT_CON2FBMAP:
 		arg = (unsigned long) compat_ptr(arg);
+		/* fall through */
 	case FBIOBLANK:
 		ret = do_fb_ioctl(info, cmd, arg);
 		break;
-- 
2.7.4

```

## Re: \[PATCH\] fbdev: fbmem: mark expected switch fall-through

- From: Bartlomiej Zolnierkiewicz \<hidden\>
- Date: 2018-07-24 15:55:19 
- Message: https://ratatoskr.run/linux-fbdev/2018/07/5341272.md

```text
On Monday, July 09, 2018 04:36:08 PM Gustavo A. R. Silva wrote:
> In preparation to enabling -Wimplicit-fallthrough, mark switch cases
> where we are expecting to fall through.
> 
> Signed-off-by: Gustavo A. R. Silva <redacted>

Patch queued for 4.19, thanks.

Best regards,
--
Bartlomiej Zolnierkiewicz
Samsung R&D Institute Poland
Samsung Electronics

```