# \[PATCH 1/4\] video: fbdev: pxafb: clear allocated memory for video modes - Subsystems: FRAMEBUFFER LAYER, THE REST - Maintainers: Helge Deller, Linus Torvalds - Status: REVIEWED ยท 1 review, 1 by a maintainer (M Robert Jarzmik) - Reviewed. - 1 review trailer. - List: linux-fbdev - 5 messages, 2 authors - Page: https://ratatoskr.run/linux-fbdev/2018/06/13466867/t ## \[PATCH 1/4\] video: fbdev: pxafb: clear allocated memory for video modes - From: Daniel Mack \ - Date: 2018-06-24 15:38:14 - Message: https://ratatoskr.run/linux-fbdev/2018/06/13466867.md ```text When parsing the video modes from DT properties, make sure to zero out memory before using it. This is important because not all fields in the mode struct are explicitly initialized, even though they are used later on. Fixes: 420a488278e86 (video: fbdev: pxafb: initial devicetree conversion) Reviewed-by: Robert Jarzmik Signed-off-by: Daniel Mack --- drivers/video/fbdev/pxafb.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/video/fbdev/pxafb.c b/drivers/video/fbdev/pxafb.c index 76722a59f55e..dfe382e68287 100644 --- a/drivers/video/fbdev/pxafb.c +++ b/drivers/video/fbdev/pxafb.c @@ -2128,8 +2128,8 @@ static int of_get_pxafb_display(struct device *dev, struct device_node *disp, return -EINVAL; ret = -ENOMEM; - info->modes = kmalloc_array(timings->num_timings, - sizeof(info->modes[0]), GFP_KERNEL); + info->modes = kcalloc(timings->num_timings, sizeof(info->modes[0]), + GFP_KERNEL); if (!info->modes) goto out; info->num_modes = timings->num_timings; -- 2.17.1 ``` ## Re: \[PATCH 1/4\] video: fbdev: pxafb: clear allocated memory for video modes - From: Daniel Mack \ - Date: 2018-07-09 05:12:50 - Message: https://ratatoskr.run/linux-fbdev/2018/07/13466885.md ```text Hi Bartlomiej, Should I resend with Robert's Reviewed-bys again? I'd like to get this merged for 4.19 if possible. Thanks, Daniel On Sunday, June 24, 2018 05:38 PM, Daniel Mack wrote: > When parsing the video modes from DT properties, make sure to zero out > memory before using it. This is important because not all fields in the mode > struct are explicitly initialized, even though they are used later on. > > Fixes: 420a488278e86 (video: fbdev: pxafb: initial devicetree conversion) > Reviewed-by: Robert Jarzmik > Signed-off-by: Daniel Mack > --- > drivers/video/fbdev/pxafb.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/video/fbdev/pxafb.c b/drivers/video/fbdev/pxafb.c > index 76722a59f55e..dfe382e68287 100644 > --- a/drivers/video/fbdev/pxafb.c > +++ b/drivers/video/fbdev/pxafb.c > @@ -2128,8 +2128,8 @@ static int of_get_pxafb_display(struct device *dev, struct device_node *disp, > return -EINVAL; > > ret = -ENOMEM; > - info->modes = kmalloc_array(timings->num_timings, > - sizeof(info->modes[0]), GFP_KERNEL); > + info->modes = kcalloc(timings->num_timings, sizeof(info->modes[0]), > + GFP_KERNEL); > if (!info->modes) > goto out; > info->num_modes = timings->num_timings; > ``` ## Re: \[PATCH 1/4\] video: fbdev: pxafb: clear allocated memory for video modes - From: Bartlomiej Zolnierkiewicz \ - Date: 2018-07-24 15:01:37 - Message: https://ratatoskr.run/linux-fbdev/2018/07/9142590.md ```text On Sunday, June 24, 2018 05:38:14 PM Daniel Mack wrote: > When parsing the video modes from DT properties, make sure to zero out > memory before using it. This is important because not all fields in the mode > struct are explicitly initialized, even though they are used later on. > > Fixes: 420a488278e86 (video: fbdev: pxafb: initial devicetree conversion) > Reviewed-by: Robert Jarzmik > Signed-off-by: Daniel Mack Patch queued for 4.19, thanks. Best regards, -- Bartlomiej Zolnierkiewicz Samsung R&D Institute Poland Samsung Electronics ``` ## Re: \[PATCH 1/4\] video: fbdev: pxafb: clear allocated memory for video modes - From: Bartlomiej Zolnierkiewicz \ - Date: 2018-07-24 15:03:43 - Message: https://ratatoskr.run/linux-fbdev/2018/07/9142594.md ```text On Monday, July 09, 2018 07:12:50 AM Daniel Mack wrote: > Hi Bartlomiej, Hi, > Should I resend with Robert's Reviewed-bys again? I'd like to get this > merged for 4.19 if possible. No need for resend, I added Robert's tags while applying your patches. Best regards, -- Bartlomiej Zolnierkiewicz Samsung R&D Institute Poland Samsung Electronics ``` ## Re: \[PATCH 1/4\] video: fbdev: pxafb: clear allocated memory for video modes - From: Daniel Mack \ - Date: 2018-07-24 15:11:37 - Message: https://ratatoskr.run/linux-fbdev/2018/07/9142635.md ```text On Tuesday, July 24, 2018 05:03 PM, Bartlomiej Zolnierkiewicz wrote: > On Monday, July 09, 2018 07:12:50 AM Daniel Mack wrote: >> Should I resend with Robert's Reviewed-bys again? I'd like to get this >> merged for 4.19 if possible. > > No need for resend, I added Robert's tags while applying your patches. Great, thank you! Daniel ```