# RE: \[PATCH V2 3/4\] clk: add managed version of clk\_bulk\_get\_all

- From: A.s. Dong \<aisheng.dong@nxp.com\>
- Date: 2018-05-25 09:51:25 
- List: linux-fbdev
- Page: https://ratatoskr.run/linux-fbdev/2018/05/5292067
- Thread: https://ratatoskr.run/linux-clk/2018/03/5240741/t.md

```text
> -----Original Message-----
> From: kbuild test robot [mailto:<redacted>]
> Sent: Friday, March 23, 2018 2:49 PM
> To: A.s. Dong <aisheng.dong@nxp.com>
> Cc: <redacted>; <redacted>; linux-
> kernel@vger.kernel.org; linux-arm-kernel@lists.infradead.org;
> mturquette@baylibre.com; hdegoede@redhat.com;
> b.zolnierkie@samsung.com; linux@armlinux.org.uk; linux-
> fbdev@vger.kernel.org; dl-linux-imx [ref];
> sboyd@kernel.org; A.s. Dong [ref]; Stephen Boyd
> [ref]
> Subject: Re: [PATCH V2 3/4] clk: add managed version of clk_bulk_get_all
> 

[...]

> All errors (new ones prefixed by >>):
> 
>    In file included from include/linux/cpufreq.h:14:0,
>                     from arch/powerpc/platforms/cell/cpufreq_spudemand.c:23:
>    include/linux/clk.h:679:1: error: expected identifier or '(' before '{' token
>     {
>     ^
> >> include/linux/clk.h:677:32: error: 'devm_clk_bulk_get_all' declared
> >> 'static' but never defined [-Werror=unused-function]
>     static inline int __must_check devm_clk_bulk_get_all(struct device *dev,
>                                    ^~~~~~~~~~~~~~~~~~~~~
>    cc1: all warnings being treated as errors
> 
> vim +677 include/linux/clk.h
> 
>    676
>  > 677	static inline int __must_check devm_clk_bulk_get_all(struct device
> *dev,
>    678							     struct
> clk_bulk_data **clks);

Thanks for the reporting.
Caused by the extra unneeded ';' at the end of the line.
Will fix.

Regards
Dong Aisheng

>  > 679	{
>    680
>    681		return 0;
>    682	}
>    683
> 
> ---
> 0-DAY kernel test infrastructure                Open Source Technology Center
> https://emea01.safelinks.protection.outlook.com/?url=https%3A%2F%2Flist
> s.01.org%2Fpipermail%2Fkbuild-
> all&data=02%7C01%7Caisheng.dong%40nxp.com%7Ce9e35f96c61a4c46d1790
> 8d5908a4d46%7C686ea1d3bc2b4c6fa92cd99c5c301635%7C0%7C0%7C6365738
> 46071200287&sdata=yIWEjcpE2tyJP%2BmsMPqn%2F83TCsxw64J%2Ba5ue73
> qGnN0%3D&reserved=0                   Intel Corporation
```