# \[PATCH 2/2\] video: udlfb: Use already defined BPP constant

- Subsystems: DISPLAYLINK USB 2.0 FRAMEBUFFER DRIVER (UDLFB), FRAMEBUFFER LAYER, THE REST
- Maintainers: Bernie Thompson, Helge Deller, Linus Torvalds
- List: linux-fbdev
- 2 messages, 2 authors
- Page: https://ratatoskr.run/linux-fbdev/2018/02/13466820/t

## \[PATCH 2/2\] video: udlfb: Use already defined BPP constant

- From: Ladislav Michl \<hidden\>
- Date: 2018-02-06 20:09:39 
- Message: https://ratatoskr.run/linux-fbdev/2018/02/13466820.md

```text
Replace const variable with already defined constant.

Signed-off-by: Ladislav Michl <redacted>
---
 drivers/video/fbdev/udlfb.c | 7 +++----
 1 file changed, 3 insertions(+), 4 deletions(-)

diff --git a/drivers/video/fbdev/udlfb.c b/drivers/video/fbdev/udlfb.c
index 45081297efa5..7b53fefb4b94 100644
--- a/drivers/video/fbdev/udlfb.c
+++ b/drivers/video/fbdev/udlfb.c
@@ -428,7 +428,6 @@ static void dlfb_compress_hline(
 	const uint16_t *pixel = *pixel_start_ptr;
 	uint32_t dev_addr  = *device_address_ptr;
 	uint8_t *cmd = *command_buffer_ptr;
-	const int bpp = 2;
 
 	while ((pixel_end > pixel) &&
 	       (cmd_buffer_end - MIN_RLX_CMD_BYTES > cmd)) {
@@ -453,9 +452,9 @@ static void dlfb_compress_hline(
 
 		cmd_pixel_end = pixel + min(MAX_CMD_PIXELS + 1,
 			min((int)(pixel_end - pixel),
-			    (int)(cmd_buffer_end - cmd) / bpp));
+			    (int)(cmd_buffer_end - cmd) / BPP));
 
-		prefetch_range((void *) pixel, (cmd_pixel_end - pixel) * bpp);
+		prefetch_range((void *) pixel, (cmd_pixel_end - pixel) * BPP);
 
 		while (pixel < cmd_pixel_end) {
 			const uint16_t * const repeating_pixel = pixel;
@@ -490,7 +489,7 @@ static void dlfb_compress_hline(
 		}
 
 		*cmd_pixels_count_byte = (pixel - cmd_pixel_start) & 0xFF;
-		dev_addr += (pixel - cmd_pixel_start) * bpp;
+		dev_addr += (pixel - cmd_pixel_start) * BPP;
 	}
 
 	if (cmd_buffer_end <= MIN_RLX_CMD_BYTES + cmd) {
-- 
2.16.1

```

## Re: \[PATCH 2/2\] video: udlfb: Use already defined BPP constant

- From: Bartlomiej Zolnierkiewicz \<hidden\>
- Date: 2018-03-12 14:44:14 
- Message: https://ratatoskr.run/linux-fbdev/2018/03/9134602.md

```text
On Tuesday, February 06, 2018 09:09:39 PM Ladislav Michl wrote:
> Replace const variable with already defined constant.
> 
> Signed-off-by: Ladislav Michl <redacted>

Patch queued for 4.17, thanks.

Best regards,
--
Bartlomiej Zolnierkiewicz
Samsung R&D Institute Poland
Samsung Electronics

```