[PATCH] video: omapfb: fix missing #includes

Subsystems: framebuffer layer, omap display subsystem and framebuffer support (dss2), the rest

STALE3104d

2 messages, 2 authors, 2018-02-08 · open the first message on its own page

[PATCH] video: omapfb: fix missing #includes

From: Tomi Valkeinen <hidden>
Date: 2018-02-08 13:24:54

Something has changed with the include files and omapfb no longer
compiles as it is not explicitly including linux/pinctrl/consumer.h and
linux/seq_file.h.

Add the missing #includes.

Signed-off-by: Tomi Valkeinen <redacted>
---

This is on top of today's Linus' master branch.


 drivers/video/fbdev/omap2/omapfb/dss/dss.c      | 1 +
 drivers/video/fbdev/omap2/omapfb/dss/hdmi_phy.c | 1 +
 drivers/video/fbdev/omap2/omapfb/dss/hdmi_pll.c | 1 +
 drivers/video/fbdev/omap2/omapfb/dss/hdmi_wp.c  | 1 +
 4 files changed, 4 insertions(+)
diff --git a/drivers/video/fbdev/omap2/omapfb/dss/dss.c b/drivers/video/fbdev/omap2/omapfb/dss/dss.c
index 39fe7247ff98..f0cac9e0eb94 100644
--- a/drivers/video/fbdev/omap2/omapfb/dss/dss.c
+++ b/drivers/video/fbdev/omap2/omapfb/dss/dss.c
@@ -40,6 +40,7 @@
 #include <linux/regulator/consumer.h>
 #include <linux/suspend.h>
 #include <linux/component.h>
+#include <linux/pinctrl/consumer.h>
 
 #include <video/omapfb_dss.h>
 
diff --git a/drivers/video/fbdev/omap2/omapfb/dss/hdmi_phy.c b/drivers/video/fbdev/omap2/omapfb/dss/hdmi_phy.c
index eee09b4bdcf6..964474b65b8b 100644
--- a/drivers/video/fbdev/omap2/omapfb/dss/hdmi_phy.c
+++ b/drivers/video/fbdev/omap2/omapfb/dss/hdmi_phy.c
@@ -14,6 +14,7 @@
 #include <linux/platform_device.h>
 #include <linux/slab.h>
 #include <video/omapfb_dss.h>
+#include <linux/seq_file.h>
 
 #include "dss.h"
 #include "hdmi.h"
diff --git a/drivers/video/fbdev/omap2/omapfb/dss/hdmi_pll.c b/drivers/video/fbdev/omap2/omapfb/dss/hdmi_pll.c
index eac3665aba6c..bc591fc12aef 100644
--- a/drivers/video/fbdev/omap2/omapfb/dss/hdmi_pll.c
+++ b/drivers/video/fbdev/omap2/omapfb/dss/hdmi_pll.c
@@ -16,6 +16,7 @@
 #include <linux/io.h>
 #include <linux/platform_device.h>
 #include <linux/clk.h>
+#include <linux/seq_file.h>
 
 #include <video/omapfb_dss.h>
 
diff --git a/drivers/video/fbdev/omap2/omapfb/dss/hdmi_wp.c b/drivers/video/fbdev/omap2/omapfb/dss/hdmi_wp.c
index 705373e4cf38..e93e7a703299 100644
--- a/drivers/video/fbdev/omap2/omapfb/dss/hdmi_wp.c
+++ b/drivers/video/fbdev/omap2/omapfb/dss/hdmi_wp.c
@@ -15,6 +15,7 @@
 #include <linux/io.h>
 #include <linux/platform_device.h>
 #include <video/omapfb_dss.h>
+#include <linux/seq_file.h>
 
 #include "dss.h"
 #include "hdmi.h"
-- 
Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki.
Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki

Re: [PATCH] video: omapfb: fix missing #includes

From: Tony Lindgren <tony@atomide.com>
Date: 2018-02-08 15:38:58

* Tomi Valkeinen [off-list ref] [180208 13:25]:
Something has changed with the include files and omapfb no longer
compiles as it is not explicitly including linux/pinctrl/consumer.h and
linux/seq_file.h.

Add the missing #includes.

Signed-off-by: Tomi Valkeinen <redacted>
---

This is on top of today's Linus' master branch.
Can you guys please send this ASAP to Linus so we'll have
a v4.16-rc1 that actually compiles and boots?

Otherwise testing and bisecting various topic branches for v4.17
will suck :( Many of them will be based on v4.16-rc1.

Thanks and feel free to add:

Tested-by: Tony Lindgren <tony@atomide.com>
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help