# \[PATCH\] console/dummy: leave .con\_font\_get set to NULL

- Subsystems: FRAMEBUFFER LAYER, CONSOLE SUBSYSTEM, THE REST
- Maintainers: Helge Deller, Greg Kroah-Hartman, Linus Torvalds
- List: linux-fbdev
- 3 messages, 2 authors
- Page: https://ratatoskr.run/linux-fbdev/2018/01/5173294/t

## \[PATCH\] console/dummy: leave .con\_font\_get set to NULL

- From: Nicolas Pitre \<hidden\>
- Date: 2018-01-05 21:43:02 
- Message: https://ratatoskr.run/linux-fbdev/2018/01/5173294.md

```text

When this method is set, the caller expects struct console_font fields
to be properly initialized when it returns. Leave it unset otherwise
nonsensical (leaked kernel stack) values are returned to user space.

Signed-off-by: Nicolas Pitre <redacted>
Cc: stable@kernel.org

diff --git a/drivers/video/console/dummycon.c b/drivers/video/console/dummycon.c
index 9269d56852..b90ef96e43 100644
--- a/drivers/video/console/dummycon.c
+++ b/drivers/video/console/dummycon.c
@@ -67,7 +67,6 @@ const struct consw dummy_con = {
     .con_switch =	DUMMY,
     .con_blank =	DUMMY,
     .con_font_set =	DUMMY,
-    .con_font_get =	DUMMY,
     .con_font_default =	DUMMY,
     .con_font_copy =	DUMMY,
 };
```

## Re: \[PATCH\] console/dummy: leave .con\_font\_get set to NULL

- From: Bartlomiej Zolnierkiewicz \<hidden\>
- Date: 2018-01-15 15:04:54 
- Message: https://ratatoskr.run/linux-fbdev/2018/01/5180870.md

```text
On Friday, January 05, 2018 04:42:58 PM Nicolas Pitre wrote:
> 
> When this method is set, the caller expects struct console_font fields
> to be properly initialized when it returns. Leave it unset otherwise
> nonsensical (leaked kernel stack) values are returned to user space.
> 
> Signed-off-by: Nicolas Pitre <redacted>
> Cc: stable@kernel.org

Please check your patches with tools/checkpatch.pl script:

ERROR: The 'stable' address should be 'stable@vger.kernel.org'
#9: 
Cc: stable@kernel.org

After updating this I queued the patch for 4.16, thanks.

Best regards,
--
Bartlomiej Zolnierkiewicz
Samsung R&D Institute Poland
Samsung Electronics

```

## Re: \[PATCH\] console/dummy: leave .con\_font\_get set to NULL

- From: Nicolas Pitre \<hidden\>
- Date: 2018-01-15 16:46:10 
- Message: https://ratatoskr.run/linux-fbdev/2018/01/5180949.md

```text
On Mon, 15 Jan 2018, Bartlomiej Zolnierkiewicz wrote:

> On Friday, January 05, 2018 04:42:58 PM Nicolas Pitre wrote:
> > 
> > When this method is set, the caller expects struct console_font fields
> > to be properly initialized when it returns. Leave it unset otherwise
> > nonsensical (leaked kernel stack) values are returned to user space.
> > 
> > Signed-off-by: Nicolas Pitre <redacted>
> > Cc: stable@kernel.org
> 
> Please check your patches with tools/checkpatch.pl script:
> 
> ERROR: The 'stable' address should be 'stable@vger.kernel.org'
> #9: 
> Cc: stable@kernel.org

Oops. I cut and pasted it it from commit ea0ee33988778fb73e4f4.  ;-)


Nicolas
```
