[PATCH] fbdev: auo_k190x: Use zeroing memory allocator than allocator/memset

Subsystems: framebuffer layer, the rest

STALE3168d

2 messages, 2 authors, 2018-01-04 · open the first message on its own page

[PATCH] fbdev: auo_k190x: Use zeroing memory allocator than allocator/memset

From: Himanshu Jha <hidden>
Date: 2017-12-31 12:26:14

Use vzalloc for allocating zeroed memory and remove unnecessary
memset function.

Done using Coccinelle.
Generated-by: scripts/coccinelle/api/alloc/kzalloc-simple.cocci
0-day tested with no failures.

Suggested-by: Luis R. Rodriguez <mcgrof@kernel.org>
Signed-off-by: Himanshu Jha <redacted>
---
 drivers/video/fbdev/auo_k190x.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/video/fbdev/auo_k190x.c b/drivers/video/fbdev/auo_k190x.c
index 0d060383..b889401 100644
--- a/drivers/video/fbdev/auo_k190x.c
+++ b/drivers/video/fbdev/auo_k190x.c
@@ -1056,13 +1056,12 @@ int auok190x_common_probe(struct platform_device *pdev,
 	/* videomemory handling */
 
 	videomemorysize = roundup((panel->w * panel->h) * 2, PAGE_SIZE);
-	videomemory = vmalloc(videomemorysize);
+	videomemory = vzalloc(videomemorysize);
 	if (!videomemory) {
 		ret = -ENOMEM;
 		goto err_irq;
 	}
 
-	memset(videomemory, 0, videomemorysize);
 	info->screen_base = (char *)videomemory;
 	info->fix.smem_len = videomemorysize;
 
-- 
2.7.4

Re: [PATCH] fbdev: auo_k190x: Use zeroing memory allocator than allocator/memset

From: Bartlomiej Zolnierkiewicz <hidden>
Date: 2018-01-04 15:50:35

On Sunday, December 31, 2017 05:55:57 PM Himanshu Jha wrote:
Use vzalloc for allocating zeroed memory and remove unnecessary
memset function.

Done using Coccinelle.
Generated-by: scripts/coccinelle/api/alloc/kzalloc-simple.cocci
Use of "Generated-by:" triggers checkpatch.pl warning + error:

WARNING: Non-standard signature: Generated-by:
#8: 
Generated-by: scripts/coccinelle/api/alloc/kzalloc-simple.cocci

ERROR: Unrecognized email address: 'scripts/coccinelle/api/alloc/kzalloc-simple.cocci'
#8: 
Generated-by: scripts/coccinelle/api/alloc/kzalloc-simple.cocci

I've changed it to "Generate-by" to silence checkpatch.pl.
0-day tested with no failures.

Suggested-by: Luis R. Rodriguez <mcgrof@kernel.org>
Signed-off-by: Himanshu Jha <redacted>
Patch queued for 4.16, thanks.

Best regards,
--
Bartlomiej Zolnierkiewicz
Samsung R&D Institute Poland
Samsung Electronics
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help