# \[PATCH 0/2\] video/fbdev/amba-clcd: Adjustments for clcdfb\_probe()

- Subsystems: FRAMEBUFFER LAYER, THE REST
- Maintainers: Helge Deller, Linus Torvalds
- Series: 2 patches touching 1 file, +1/-2
- List: linux-fbdev
- 5 messages, 2 authors
- Page: https://ratatoskr.run/linux-fbdev/2017/12/5149640/t

## \[PATCH 0/2\] video/fbdev/amba-clcd: Adjustments for clcdfb\_probe()

- From: SF Markus Elfring \<hidden\>
- Date: 2017-12-05 17:11:28 
- Message: https://ratatoskr.run/linux-fbdev/2017/12/5149640.md

```text
From: Markus Elfring <redacted>
Date: Tue, 5 Dec 2017 18:07:06 +0100

Two update suggestions were taken into account
from static source code analysis.

Markus Elfring (2):
  Delete an error message for a failed memory allocation
  Improve a size determination

 drivers/video/fbdev/amba-clcd.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

-- 
2.15.1

```

## \[PATCH 1/2\] video: ARM CLCD: Delete an error message for a failed memory allocation in clcdfb\_probe()

- From: SF Markus Elfring \<hidden\>
- Date: 2017-12-05 17:12:48 
- Message: https://ratatoskr.run/linux-fbdev/2017/12/5149645.md

```text
From: Markus Elfring <redacted>
Date: Tue, 5 Dec 2017 17:50:11 +0100

Omit an extra message for a memory allocation failure in this function.

This issue was detected by using the Coccinelle software.

Signed-off-by: Markus Elfring <redacted>
---
 drivers/video/fbdev/amba-clcd.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/video/fbdev/amba-clcd.c b/drivers/video/fbdev/amba-clcd.c
index 36d25190b48c..79f5ebf23fcd 100644
--- a/drivers/video/fbdev/amba-clcd.c
+++ b/drivers/video/fbdev/amba-clcd.c
@@ -969,7 +969,6 @@ static int clcdfb_probe(struct amba_device *dev, const struct amba_id *id)
 
 	fb = kzalloc(sizeof(struct clcd_fb), GFP_KERNEL);
 	if (!fb) {
-		printk(KERN_INFO "CLCD: could not allocate new clcd_fb struct\n");
 		ret = -ENOMEM;
 		goto free_region;
 	}
-- 
2.15.1

```

## \[PATCH 2/2\] video: ARM CLCD: Improve a size determination in clcdfb\_probe()

- From: SF Markus Elfring \<hidden\>
- Date: 2017-12-05 17:14:25 
- Message: https://ratatoskr.run/linux-fbdev/2017/12/5149649.md

```text
From: Markus Elfring <redacted>
Date: Tue, 5 Dec 2017 17:53:19 +0100

Replace the specification of a data structure by a pointer dereference
as the parameter for the operator "sizeof" to make the corresponding size
determination a bit safer according to the Linux coding style convention.

This issue was detected by using the Coccinelle software.

Signed-off-by: Markus Elfring <redacted>
---
 drivers/video/fbdev/amba-clcd.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/video/fbdev/amba-clcd.c b/drivers/video/fbdev/amba-clcd.c
index 79f5ebf23fcd..38c1f324ce15 100644
--- a/drivers/video/fbdev/amba-clcd.c
+++ b/drivers/video/fbdev/amba-clcd.c
@@ -967,7 +967,7 @@ static int clcdfb_probe(struct amba_device *dev, const struct amba_id *id)
 		goto out;
 	}
 
-	fb = kzalloc(sizeof(struct clcd_fb), GFP_KERNEL);
+	fb = kzalloc(sizeof(*fb), GFP_KERNEL);
 	if (!fb) {
 		ret = -ENOMEM;
 		goto free_region;
-- 
2.15.1

```

## Re: \[PATCH 1/2\] video: ARM CLCD: Delete an error message for a failed memory allocation in clcdfb\_probe()

- From: Bartlomiej Zolnierkiewicz \<hidden\>
- Date: 2018-03-28 14:13:58 
- Message: https://ratatoskr.run/linux-fbdev/2018/03/5244836.md

```text
On Tuesday, December 05, 2017 06:12:30 PM SF Markus Elfring wrote:
> From: Markus Elfring <redacted>
> Date: Tue, 5 Dec 2017 17:50:11 +0100
> 
> Omit an extra message for a memory allocation failure in this function.
> 
> This issue was detected by using the Coccinelle software.
> 
> Signed-off-by: Markus Elfring <redacted>

Patch queued for 4.17, thanks.

Best regards,
--
Bartlomiej Zolnierkiewicz
Samsung R&D Institute Poland
Samsung Electronics

```

## Re: \[PATCH 2/2\] video: ARM CLCD: Improve a size determination in clcdfb\_probe()

- From: Bartlomiej Zolnierkiewicz \<hidden\>
- Date: 2018-03-28 14:17:06 
- Message: https://ratatoskr.run/linux-fbdev/2018/03/5244839.md

```text
On Tuesday, December 05, 2017 06:13:33 PM SF Markus Elfring wrote:
> From: Markus Elfring <redacted>
> Date: Tue, 5 Dec 2017 17:53:19 +0100
> 
> Replace the specification of a data structure by a pointer dereference
> as the parameter for the operator "sizeof" to make the corresponding size
> determination a bit safer according to the Linux coding style convention.
> 
> This issue was detected by using the Coccinelle software.
> 
> Signed-off-by: Markus Elfring <redacted>

Patch queued for 4.17, thanks.

Best regards,
--
Bartlomiej Zolnierkiewicz
Samsung R&D Institute Poland
Samsung Electronics

```