[PATCH] video: fbdev: remove redundant self assignment of 'height'

Subsystems: framebuffer layer, the rest

STALE3141d

2 messages, 2 authors, 2017-12-29 · open the first message on its own page

[PATCH] video: fbdev: remove redundant self assignment of 'height'

From: Colin King <hidden>
Date: 2017-11-23 10:55:59

From: Colin Ian King <redacted>

The assignment of height to itself is redundant and can be removed.
Detected with Coccinelle.

Signed-off-by: Colin Ian King <redacted>
---
 drivers/video/fbdev/vga16fb.c | 1 -
 1 file changed, 1 deletion(-)
diff --git a/drivers/video/fbdev/vga16fb.c b/drivers/video/fbdev/vga16fb.c
index 5f0690c8fc93..2c6a576ed84c 100644
--- a/drivers/video/fbdev/vga16fb.c
+++ b/drivers/video/fbdev/vga16fb.c
@@ -1055,7 +1055,6 @@ static void vga16fb_copyarea(struct fb_info *info, const struct fb_copyarea *are
 	case FB_TYPE_VGA_PLANES:
 		if (info->fix.type_aux = FB_AUX_VGA_PLANES_VGA4) {
 			width = width/8;
-			height = height;
 			line_ofs = info->fix.line_length - width;
 
 			setmode(1);
-- 
2.14.1

Re: [PATCH] video: fbdev: remove redundant self assignment of 'height'

From: Bartlomiej Zolnierkiewicz <hidden>
Date: 2017-12-29 17:37:00

On Thursday, November 23, 2017 10:55:53 AM Colin King wrote:
From: Colin Ian King <redacted>

The assignment of height to itself is redundant and can be removed.
Detected with Coccinelle.

Signed-off-by: Colin Ian King <redacted>
Patch queued for 4.16, thanks.

Best regards,
--
Bartlomiej Zolnierkiewicz
Samsung R&D Institute Poland
Samsung Electronics
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help