From: H. Nikolaus Schaller <hidden> Date: 2017-11-08 21:11:26
This patch set fixes vendor names of the panels
and fixes a problem on omapdrm with enabling
VDD_DSI for OMAP3 which is needed for displaying
the Red and Green channel on OMAP3530 (Pandora).
H. Nikolaus Schaller (4):
omapdrm: fix compatible string for td028ttec1
DTS: GTA04: fix panel compatibility string
DTS: Pandora: fix panel compatibility string
omapdss: fix problem enabling VDDS_DSI on OMAP3530 (OpenPandora)
.../display/panel/{toppoly,td028ttec1.txt => tpo,td028ttec1.txt} | 4 ++--
arch/arm/boot/dts/omap3-gta04.dtsi | 2 +-
arch/arm/boot/dts/omap3-pandora-common.dtsi | 2 +-
drivers/gpu/drm/omapdrm/displays/panel-tpo-td028ttec1.c | 4 ++--
drivers/gpu/drm/omapdrm/dss/dpi.c | 3 +--
drivers/video/fbdev/omap2/omapfb/displays/panel-tpo-td028ttec1.c | 4 ++--
6 files changed, 9 insertions(+), 10 deletions(-)
rename Documentation/devicetree/bindings/display/panel/{toppoly,td028ttec1.txt => tpo,td028ttec1.txt} (84%)
--
2.12.2
From: H. Nikolaus Schaller <hidden> Date: 2017-11-08 21:10:23
The vendor name was "toppoly" but other panels and the vendor list
have defined it as "tpo". So let's fix it in driver and bindings.
Signed-off-by: H. Nikolaus Schaller <redacted>
---
.../display/panel/{toppoly,td028ttec1.txt => tpo,td028ttec1.txt} | 4 ++--
drivers/gpu/drm/omapdrm/displays/panel-tpo-td028ttec1.c | 4 ++--
drivers/video/fbdev/omap2/omapfb/displays/panel-tpo-td028ttec1.c | 4 ++--
3 files changed, 6 insertions(+), 6 deletions(-)
rename Documentation/devicetree/bindings/display/panel/{toppoly,td028ttec1.txt => tpo,td028ttec1.txt} (84%)
diff --git a/Documentation/devicetree/bindings/display/panel/toppoly,td028ttec1.txt b/Documentation/devicetree/bindings/display/panel/tpo,td028ttec1.txtsimilarity index 84%rename from Documentation/devicetree/bindings/display/panel/toppoly,td028ttec1.txtrename to Documentation/devicetree/bindings/display/panel/tpo,td028ttec1.txtindex 7175dc3740ac..ed34253d9fb1 100644--- a/Documentation/devicetree/bindings/display/panel/toppoly,td028ttec1.txt+++ b/Documentation/devicetree/bindings/display/panel/tpo,td028ttec1.txt
@@ -2,7 +2,7 @@ Toppoly TD028TTEC1 Panel ============ Required properties:-- compatible: "toppoly,td028ttec1"+- compatible: "tpo,td028ttec1" Optional properties: - label: a symbolic name for the panel
From: H. Nikolaus Schaller <hidden> Date: 2017-11-08 21:10:27
commit d178e034d565 ("drm: omapdrm: Move FEAT_DPI_USES_VDDS_DSI feature to dpi code")
introduced a new match table which turned out to be wrong, at least
for the 600 MHz OpenPandora using the OMAP3530.
The effect was strange: only the Blue channel of the RGB panel was
driven while Red and Green stayed black. So a coloured picture turned
into blue/black.
The GTA04 with DM3730 didn't show the effect.
It turned out that VDDS_DSI was not properly initialized on OMAP3530,
because the .family string is just "OMAP3" for these processors and
not "OMAP3xxx".
Therefore we match the .machine attribute.
Signed-off-by: H. Nikolaus Schaller <redacted>
---
drivers/gpu/drm/omapdrm/dss/dpi.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
Hi Nikolaus,
Thank you for the patch.
On Wednesday, 8 November 2017 23:09:29 EET H. Nikolaus Schaller wrote:
quoted hunk
The vendor name was "toppoly" but other panels and the vendor list
have defined it as "tpo". So let's fix it in driver and bindings.
Signed-off-by: H. Nikolaus Schaller <redacted>
---
.../display/panel/{toppoly,td028ttec1.txt => tpo,td028ttec1.txt} | 4 ++--
drivers/gpu/drm/omapdrm/displays/panel-tpo-td028ttec1.c | 4 ++--
drivers/video/fbdev/omap2/omapfb/displays/panel-tpo-td028ttec1.c | 4 ++--
3 files changed, 6 insertions(+), 6 deletions(-)
rename
Documentation/devicetree/bindings/display/panel/{toppoly,td028ttec1.txt =>
tpo,td028ttec1.txt} (84%)
diff --git
a/Documentation/devicetree/bindings/display/panel/toppoly,td028ttec1.txt
b/Documentation/devicetree/bindings/display/panel/tpo,td028ttec1.txt
similarity index 84%
rename from
Documentation/devicetree/bindings/display/panel/toppoly,td028ttec1.txt
rename to
Documentation/devicetree/bindings/display/panel/tpo,td028ttec1.txt index
7175dc3740ac..ed34253d9fb1 100644
--- a/Documentation/devicetree/bindings/display/panel/toppoly,td028ttec1.txt+++ b/Documentation/devicetree/bindings/display/panel/tpo,td028ttec1.txt @@
-2,7 +2,7 @@ Toppoly TD028TTEC1 Panel
============
Required properties:
-- compatible: "toppoly,td028ttec1"
+- compatible: "tpo,td028ttec1"
Optional properties:
- label: a symbolic name for the panel
Hi Nikolaus,
Thank you for the patch.
On Wednesday, 8 November 2017 23:09:32 EET H. Nikolaus Schaller wrote:
commit d178e034d565 ("drm: omapdrm: Move FEAT_DPI_USES_VDDS_DSI feature to
dpi code")
introduced a new match table which turned out to be wrong, at least
for the 600 MHz OpenPandora using the OMAP3530.
The effect was strange: only the Blue channel of the RGB panel was
driven while Red and Green stayed black. So a coloured picture turned
into blue/black.
The GTA04 with DM3730 didn't show the effect.
It turned out that VDDS_DSI was not properly initialized on OMAP3530,
because the .family string is just "OMAP3" for these processors and
not "OMAP3xxx".
Therefore we match the .machine attribute.
Signed-off-by: H. Nikolaus Schaller <redacted>
I've already submitted a similar patch (but without the problem pointed out
below) in the mail thread where we discussed the issue. It is customary to use
the first patch posted (unless it is utterly broken of course). Could you thus
please include it in this series in replacement of this patch ?
@@ -566,8 +566,7 @@ static int dpi_verify_pll(struct dss_pll *pll)}staticconststructsoc_device_attributedpi_soc_devices[]={-{.family="OMAP3[456]*"},-{.family="[AD]M37*"},+{.machine="OMAP3[456]*"},
You also need
{ .machine = "[AD]M37*" },
otherwise there will be no match for the OMAP3-like AM37xx and DM37xx SoCs.
Another option would be to match on { .family = "OMAP3*" } but there could be
spurious matches, even though I haven't identified any.
From: H. Nikolaus Schaller <hidden> Date: 2017-11-09 06:05:56
Hi Laurent,
Am 09.11.2017 um 04:33 schrieb Laurent Pinchart [off-list ref]:
Hi Nikolaus,
Thank you for the patch.
On Wednesday, 8 November 2017 23:09:29 EET H. Nikolaus Schaller wrote:
quoted
The vendor name was "toppoly" but other panels and the vendor list
have defined it as "tpo". So let's fix it in driver and bindings.
Signed-off-by: H. Nikolaus Schaller <redacted>
---
.../display/panel/{toppoly,td028ttec1.txt => tpo,td028ttec1.txt} | 4 ++--
drivers/gpu/drm/omapdrm/displays/panel-tpo-td028ttec1.c | 4 ++--
drivers/video/fbdev/omap2/omapfb/displays/panel-tpo-td028ttec1.c | 4 ++--
3 files changed, 6 insertions(+), 6 deletions(-)
rename
Documentation/devicetree/bindings/display/panel/{toppoly,td028ttec1.txt =>
tpo,td028ttec1.txt} (84%)
diff --git
a/Documentation/devicetree/bindings/display/panel/toppoly,td028ttec1.txt
b/Documentation/devicetree/bindings/display/panel/tpo,td028ttec1.txt
similarity index 84%
rename from
Documentation/devicetree/bindings/display/panel/toppoly,td028ttec1.txt
rename to
Documentation/devicetree/bindings/display/panel/tpo,td028ttec1.txt index
7175dc3740ac..ed34253d9fb1 100644
========================
Required properties:
-- compatible: "toppoly,td028ttec1"
+- compatible: "tpo,td028ttec1"
Optional properties:
- label: a symbolic name for the panel
From: H. Nikolaus Schaller <hidden> Date: 2017-11-09 06:07:09
Am 09.11.2017 um 04:36 schrieb Laurent Pinchart [off-list ref]:
Hi Nikolaus,
Thank you for the patch.
On Wednesday, 8 November 2017 23:09:31 EET H. Nikolaus Schaller wrote:
quoted
We can remove the "omapdss," prefix.
I agree but you should explain why.
I can add a sentence if someone helps me to formulate it correctly.
Or Tomi, please add when accepting the patch.
From: H. Nikolaus Schaller <hidden> Date: 2017-11-09 06:13:03
Hi Laurent,
Am 09.11.2017 um 04:45 schrieb Laurent Pinchart [off-list ref]:
Hi Nikolaus,
Thank you for the patch.
On Wednesday, 8 November 2017 23:09:32 EET H. Nikolaus Schaller wrote:
quoted
commit d178e034d565 ("drm: omapdrm: Move FEAT_DPI_USES_VDDS_DSI feature to
dpi code")
introduced a new match table which turned out to be wrong, at least
for the 600 MHz OpenPandora using the OMAP3530.
The effect was strange: only the Blue channel of the RGB panel was
driven while Red and Green stayed black. So a coloured picture turned
into blue/black.
The GTA04 with DM3730 didn't show the effect.
It turned out that VDDS_DSI was not properly initialized on OMAP3530,
because the .family string is just "OMAP3" for these processors and
not "OMAP3xxx".
Therefore we match the .machine attribute.
Signed-off-by: H. Nikolaus Schaller <redacted>
I've already submitted a similar patch (but without the problem pointed out
below) in the mail thread where we discussed the issue. It is customary to use
the first patch posted (unless it is utterly broken of course).
Ah sorry. My workflow isn't well prepared for that and I already had committed
something to my private branch...
Could you thus
please include it in this series in replacement of this patch ?
Well, you can as well reject my patch (it is just a proposal) and take yours
as a replacement. Especially as you better understand all the potential values
for .family and .machine than me.
Should be less work for both of us.
Hi Nikolaus,
On Thursday, 9 November 2017 08:05:15 EET H. Nikolaus Schaller wrote:
quoted
Am 09.11.2017 um 04:33 schrieb Laurent Pinchart:
On Wednesday, 8 November 2017 23:09:29 EET H. Nikolaus Schaller wrote:
quoted
The vendor name was "toppoly" but other panels and the vendor list
have defined it as "tpo". So let's fix it in driver and bindings.
Signed-off-by: H. Nikolaus Schaller <redacted>
---
.../display/panel/{toppoly,td028ttec1.txt => tpo,td028ttec1.txt} | 4 ++--
drivers/gpu/drm/omapdrm/displays/panel-tpo-td028ttec1.c | 4
++--
drivers/video/fbdev/omap2/omapfb/displays/panel-tpo-td028ttec1.c | 4
++--
3 files changed, 6 insertions(+), 6 deletions(-)
rename
Documentation/devicetree/bindings/display/panel/{toppoly,td028ttec1.txt
=>
tpo,td028ttec1.txt} (84%)
diff --git
a/Documentation/devicetree/bindings/display/panel/toppoly,td028ttec1.txt
b/Documentation/devicetree/bindings/display/panel/tpo,td028ttec1.txt
similarity index 84%
rename from
Documentation/devicetree/bindings/display/panel/toppoly,td028ttec1.txt
rename to
Documentation/devicetree/bindings/display/panel/tpo,td028ttec1.txt index
7175dc3740ac..ed34253d9fb1 100644
---
a/Documentation/devicetree/bindings/display/panel/toppoly,td028ttec1.txt
============
Required properties:
-- compatible: "toppoly,td028ttec1"
+- compatible: "tpo,td028ttec1"
Optional properties:
- label: a symbolic name for the panel
Doesn't this break backward compatibility with existing DT ?
Yes, it does. But I am only aware of the GTA04 which uses it and
there is a separate fix).
DT is supposed to be an ABI. In theory at least, one could boot a GTA04 with
an existing DT and a new kernel, and no regression should be noticed. There
could also be other devices using this panel that you are not aware of.
For how to apply the theory to real life, I'll defer to Tomi :-)
From: H. Nikolaus Schaller <hidden> Date: 2017-11-09 06:48:42
Hi Laurent,
Am 09.11.2017 um 07:35 schrieb Laurent Pinchart [off-list ref]:
Hi Nikolaus,
On Thursday, 9 November 2017 08:05:15 EET H. Nikolaus Schaller wrote:
quoted
quoted
Am 09.11.2017 um 04:33 schrieb Laurent Pinchart:
On Wednesday, 8 November 2017 23:09:29 EET H. Nikolaus Schaller wrote:
quoted
The vendor name was "toppoly" but other panels and the vendor list
have defined it as "tpo". So let's fix it in driver and bindings.
Signed-off-by: H. Nikolaus Schaller <redacted>
---
.../display/panel/{toppoly,td028ttec1.txt => tpo,td028ttec1.txt} | 4 ++--
drivers/gpu/drm/omapdrm/displays/panel-tpo-td028ttec1.c | 4
++--
drivers/video/fbdev/omap2/omapfb/displays/panel-tpo-td028ttec1.c | 4
++--
3 files changed, 6 insertions(+), 6 deletions(-)
rename
Documentation/devicetree/bindings/display/panel/{toppoly,td028ttec1.txt
=>
tpo,td028ttec1.txt} (84%)
diff --git
a/Documentation/devicetree/bindings/display/panel/toppoly,td028ttec1.txt
b/Documentation/devicetree/bindings/display/panel/tpo,td028ttec1.txt
similarity index 84%
rename from
Documentation/devicetree/bindings/display/panel/toppoly,td028ttec1.txt
rename to
Documentation/devicetree/bindings/display/panel/tpo,td028ttec1.txt index
7175dc3740ac..ed34253d9fb1 100644
---
a/Documentation/devicetree/bindings/display/panel/toppoly,td028ttec1.txt
========================
Required properties:
-- compatible: "toppoly,td028ttec1"
+- compatible: "tpo,td028ttec1"
Optional properties:
- label: a symbolic name for the panel
Doesn't this break backward compatibility with existing DT ?
Yes, it does. But I am only aware of the GTA04 which uses it and
there is a separate fix).
DT is supposed to be an ABI. In theory at least, one could boot a GTA04 with
an existing DT and a new kernel, and no regression should be noticed.
Yes, indeed...
There
could also be other devices using this panel that you are not aware of.
For how to apply the theory to real life, I'll defer to Tomi :-)
Yes, Tomi should decide if we should keep the old compatible string in
the driver (in second place so to avoid a speed penalty)...
BR and thanks,
Nikolaus Schaller