[PATCH] video: fbdev: sm501fb: mark expected switch fall-through in sm501fb_blank_crt

Subsystems: framebuffer layer, the rest

STALE3193d

2 messages, 2 authors, 2017-11-09 · open the first message on its own page

[PATCH] video: fbdev: sm501fb: mark expected switch fall-through in sm501fb_blank_crt

From: Gustavo A. R. Silva <hidden>
Date: 2017-11-06 22:31:22

In preparation to enabling -Wimplicit-fallthrough, mark switch cases
where we are expecting to fall through.

Signed-off-by: Gustavo A. R. Silva <redacted>
---
 drivers/video/fbdev/sm501fb.c | 1 +
 1 file changed, 1 insertion(+)
diff --git a/drivers/video/fbdev/sm501fb.c b/drivers/video/fbdev/sm501fb.c
index 076dd27..7085cc0 100644
--- a/drivers/video/fbdev/sm501fb.c
+++ b/drivers/video/fbdev/sm501fb.c
@@ -1008,6 +1008,7 @@ static int sm501fb_blank_crt(int blank_mode, struct fb_info *info)
 	case FB_BLANK_POWERDOWN:
 		ctrl &= ~SM501_DC_CRT_CONTROL_ENABLE;
 		sm501_misc_control(fbi->dev->parent, SM501_MISC_DAC_POWER, 0);
+		/* fall through */
 
 	case FB_BLANK_NORMAL:
 		ctrl |= SM501_DC_CRT_CONTROL_BLANK;
-- 
2.7.4

Re: [PATCH] video: fbdev: sm501fb: mark expected switch fall-through in sm501fb_blank_crt

From: Bartlomiej Zolnierkiewicz <hidden>
Date: 2017-11-09 15:57:23

On Monday, November 06, 2017 04:31:18 PM Gustavo A. R. Silva wrote:
In preparation to enabling -Wimplicit-fallthrough, mark switch cases
where we are expecting to fall through.

Signed-off-by: Gustavo A. R. Silva <redacted>
Patch queued for 4.15, thanks.

Best regards,
--
Bartlomiej Zolnierkiewicz
Samsung R&D Institute Poland
Samsung Electronics
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help