[PATCH] video: ARM CLCD: constify amba_id

Subsystems: framebuffer layer, the rest

STALE3296d

2 messages, 2 authors, 2017-09-04 · open the first message on its own page

[PATCH] video: ARM CLCD: constify amba_id

From: Arvind Yadav <hidden>
Date: 2017-08-23 17:25:39

amba_id are not supposed to change at runtime. All functions
working with const amba_id. So mark the non-const structs as const.

Signed-off-by: Arvind Yadav <redacted>
---
 drivers/video/fbdev/amba-clcd.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/video/fbdev/amba-clcd.c b/drivers/video/fbdev/amba-clcd.c
index ffc2c33c..36d2519 100644
--- a/drivers/video/fbdev/amba-clcd.c
+++ b/drivers/video/fbdev/amba-clcd.c
@@ -1035,7 +1035,7 @@ static struct clcd_vendor_data vendor_nomadik = {
 	.init_panel = nomadik_clcd_init_panel,
 };
 
-static struct amba_id clcdfb_id_table[] = {
+static const struct amba_id clcdfb_id_table[] = {
 	{
 		.id	= 0x00041110,
 		.mask	= 0x000ffffe,
-- 
2.7.4

Re: [PATCH] video: ARM CLCD: constify amba_id

From: Bartlomiej Zolnierkiewicz <hidden>
Date: 2017-09-04 12:59:53

On Wednesday, August 23, 2017 10:55:26 PM Arvind Yadav wrote:
amba_id are not supposed to change at runtime. All functions
working with const amba_id. So mark the non-const structs as const.

Signed-off-by: Arvind Yadav <redacted>
Patch queued for 4.14, thanks.

Best regards,
--
Bartlomiej Zolnierkiewicz
Samsung R&D Institute Poland
Samsung Electronics
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help