# Re: \[PATCH\] video: fbdev: pxa3xx\_gcu: fix error return code in pxa3xx\_gcu\_probe()

- From: Bartlomiej Zolnierkiewicz \<hidden\>
- Date: 2017-08-21 14:18:05 
- List: linux-fbdev
- Page: https://ratatoskr.run/linux-fbdev/2017/08/5072157
- Thread: https://ratatoskr.run/linux-fbdev/2017/08/5062474/t.md

```text
On Tuesday, August 08, 2017 05:17:30 PM Gustavo A. R. Silva wrote:
> platform_get_irq() returns an error code, but the pxa3xx_gcu driver
> ignores it and always returns -ENODEV. This is not correct and,
> prevents -EPROBE_DEFER from being propagated properly.
> 
> Also, notice that platform_get_irq() no longer returns 0 on error:
> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?idã30b9a6bb35dc7097a4f02cb1ae7b6f96df92af
> 
> Print and propagate the return value of platform_get_irq on failure.
> 
> This issue was detected with the help of Coccinelle.
> 
> Signed-off-by: Gustavo A. R. Silva <redacted>

Patch queued for 4.14, thanks.

Best regards,
--
Bartlomiej Zolnierkiewicz
Samsung R&D Institute Poland
Samsung Electronics

```