# \[PATCH\] omapfb: constify omap\_video\_timings structures

- Subsystems: FRAMEBUFFER LAYER, OMAP DISPLAY SUBSYSTEM and FRAMEBUFFER SUPPORT (DSS2), THE REST
- Maintainers: Helge Deller, Linus Torvalds
- List: linux-fbdev
- 2 messages, 2 authors
- Page: https://ratatoskr.run/linux-fbdev/2017/08/5065731/t

## \[PATCH\] omapfb: constify omap\_video\_timings structures

- From: Julia Lawall \<hidden\>
- Date: 2017-08-12 06:46:13 
- Message: https://ratatoskr.run/linux-fbdev/2017/08/5065731.md

```text
These omap_video_timings structures are only copied into other
structures, so they can be const.

Done with the help of Coccinelle.

Signed-off-by: Julia Lawall <redacted>

---
 drivers/video/fbdev/omap2/omapfb/displays/panel-lgphilips-lb035q02.c |    2 +-
 drivers/video/fbdev/omap2/omapfb/displays/panel-tpo-td028ttec1.c     |    2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/video/fbdev/omap2/omapfb/displays/panel-lgphilips-lb035q02.c b/drivers/video/fbdev/omap2/omapfb/displays/panel-lgphilips-lb035q02.c
index f14691c..6cd759c 100644
--- a/drivers/video/fbdev/omap2/omapfb/displays/panel-lgphilips-lb035q02.c
+++ b/drivers/video/fbdev/omap2/omapfb/displays/panel-lgphilips-lb035q02.c
@@ -18,7 +18,7 @@
 
 #include <video/omapfb_dss.h>
 
-static struct omap_video_timings lb035q02_timings = {
+static const struct omap_video_timings lb035q02_timings = {
 	.x_res = 320,
 	.y_res = 240,
 
diff --git a/drivers/video/fbdev/omap2/omapfb/displays/panel-tpo-td028ttec1.c b/drivers/video/fbdev/omap2/omapfb/displays/panel-tpo-td028ttec1.c
index b529a8c..57e9e14 100644
--- a/drivers/video/fbdev/omap2/omapfb/displays/panel-tpo-td028ttec1.c
+++ b/drivers/video/fbdev/omap2/omapfb/displays/panel-tpo-td028ttec1.c
@@ -41,7 +41,7 @@ struct panel_drv_data {
 	struct spi_device *spi_dev;
 };
 
-static struct omap_video_timings td028ttec1_panel_timings = {
+static const struct omap_video_timings td028ttec1_panel_timings = {
 	.x_res		= 480,
 	.y_res		= 640,
 	.pixelclock	= 22153000,

```

## Re: \[PATCH\] omapfb: constify omap\_video\_timings structures

- From: Bartlomiej Zolnierkiewicz \<hidden\>
- Date: 2017-08-21 14:48:31 
- Message: https://ratatoskr.run/linux-fbdev/2017/08/5072180.md

```text
On Saturday, August 12, 2017 08:20:36 AM Julia Lawall wrote:
> These omap_video_timings structures are only copied into other
> structures, so they can be const.
> 
> Done with the help of Coccinelle.
> 
> Signed-off-by: Julia Lawall <redacted>

Patch queued for 4.14, thanks.

Best regards,
--
Bartlomiej Zolnierkiewicz
Samsung R&D Institute Poland
Samsung Electronics

```