# \[PATCH\] video: fbdev: vt8623fb: constify vt8623\_timing\_regs

- Subsystems: FRAMEBUFFER LAYER, THE REST
- Maintainers: Helge Deller, Linus Torvalds
- List: linux-fbdev
- 2 messages, 2 authors
- Page: https://ratatoskr.run/linux-fbdev/2017/08/5058971/t

## \[PATCH\] video: fbdev: vt8623fb: constify vt8623\_timing\_regs

- From: Julia Lawall \<hidden\>
- Date: 2017-08-03 19:53:09 
- Message: https://ratatoskr.run/linux-fbdev/2017/08/5058971.md

```text
vt8623_timing_regs is only passed as the first argument to
svga_check_timings and as the second argument to svga_set_timings,
both of which are const.  So make vt8623_timing_regs const also.

Done with the help of Coccinelle.

Signed-off-by: Julia Lawall <redacted>

---
 drivers/video/fbdev/vt8623fb.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/video/fbdev/vt8623fb.c b/drivers/video/fbdev/vt8623fb.c
index 9f34879..5cac871 100644
--- a/drivers/video/fbdev/vt8623fb.c
+++ b/drivers/video/fbdev/vt8623fb.c
@@ -81,7 +81,7 @@ struct vt8623fb_info {
 static struct vga_regset vt8623_fetch_count_regs[]   = {{0x1C, 0, 7}, {0x1D, 0, 1}, VGA_REGSET_END};
 static struct vga_regset vt8623_start_address_regs[] = {{0x0d, 0, 7}, {0x0c, 0, 7}, {0x34, 0, 7}, {0x48, 0, 1}, VGA_REGSET_END};
 
-static struct svga_timing_regs vt8623_timing_regs     = {
+static const struct svga_timing_regs vt8623_timing_regs     = {
 	vt8623_h_total_regs, vt8623_h_display_regs, vt8623_h_blank_start_regs,
 	vt8623_h_blank_end_regs, vt8623_h_sync_start_regs, vt8623_h_sync_end_regs,
 	vt8623_v_total_regs, vt8623_v_display_regs, vt8623_v_blank_start_regs,

```

## Re: \[PATCH\] video: fbdev: vt8623fb: constify vt8623\_timing\_regs

- From: Bartlomiej Zolnierkiewicz \<hidden\>
- Date: 2017-08-18 17:51:21 
- Message: https://ratatoskr.run/linux-fbdev/2017/08/5070940.md

```text
On Thursday, August 03, 2017 09:27:39 PM Julia Lawall wrote:
> vt8623_timing_regs is only passed as the first argument to
> svga_check_timings and as the second argument to svga_set_timings,
> both of which are const.  So make vt8623_timing_regs const also.
> 
> Done with the help of Coccinelle.
> 
> Signed-off-by: Julia Lawall <redacted>

Patch queued for 4.14, thanks.

Best regards,
--
Bartlomiej Zolnierkiewicz
Samsung R&D Institute Poland
Samsung Electronics

```