# \[PATCH\] fbdev: fix 1bpp logo for unusual width - Subsystems: FRAMEBUFFER LAYER, FRAMEBUFFER CORE, THE REST - Maintainers: Helge Deller, Simona Vetter, Linus Torvalds - List: linux-fbdev - 2 messages, 2 authors - Page: https://ratatoskr.run/linux-fbdev/2017/07/5054594/t ## \[PATCH\] fbdev: fix 1bpp logo for unusual width - From: David Lechner \ - Date: 2017-07-28 20:34:04 - Message: https://ratatoskr.run/linux-fbdev/2017/07/5054594.md ```text This check is needed in the case where the width of the framebuffer is not a multiple of 8 pixels. For example, LEGO MINDSTORMS EV3 has a 178x128 1bpp display. Signed-off-by: David Lechner --- drivers/video/fbdev/core/fbmem.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/video/fbdev/core/fbmem.c b/drivers/video/fbdev/core/fbmem.c index 7a42238..805a42c 100644 --- a/drivers/video/fbdev/core/fbmem.c +++ b/drivers/video/fbdev/core/fbmem.c @@ -315,7 +315,7 @@ static void fb_set_logo(struct fb_info *info, for (i = 0; i < logo->height; i++) { for (j = 0; j < logo->width; src++) { d = *src ^ xor; - for (k = 7; k >= 0; k--) { + for (k = 7; k >= 0 && j < logo->width; k--) { *dst++ = ((d >> k) & 1) ? fg : 0; j++; } -- 2.7.4 ``` ## Re: \[PATCH\] fbdev: fix 1bpp logo for unusual width - From: Bartlomiej Zolnierkiewicz \ - Date: 2017-08-18 17:24:27 - Message: https://ratatoskr.run/linux-fbdev/2017/08/5070924.md ```text On Friday, July 28, 2017 03:33:53 PM David Lechner wrote: > This check is needed in the case where the width of the framebuffer > is not a multiple of 8 pixels. For example, LEGO MINDSTORMS EV3 has > a 178x128 1bpp display. > > Signed-off-by: David Lechner Patch queued for 4.14, thanks. Best regards, -- Bartlomiej Zolnierkiewicz Samsung R&D Institute Poland Samsung Electronics ```