[PATCH v2] staging: sm750fb: refactor method and fix potential type inconsistence

Subsystems: staging - silicon motion sm750 frame buffer driver, staging subsystem, the rest

STALE3356d

2 messages, 2 authors, 2017-07-03 · open the first message on its own page

[PATCH v2] staging: sm750fb: refactor method and fix potential type inconsistence

From: Lynn Lei <hidden>
Date: 2017-07-02 14:40:52 

include PANEL_DISPLAY_CTRL_FPVDDEN control mask

Signed-off-by: Lynn Lei <redacted>
---
 drivers/staging/sm750fb/ddk750_display.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/staging/sm750fb/ddk750_display.c b/drivers/staging/sm750fb/ddk750_display.c
index 0f666dc2729a..c68367e6cdeb 100644
--- a/drivers/staging/sm750fb/ddk750_display.c
+++ b/drivers/staging/sm750fb/ddk750_display.c
@@ -89,7 +89,7 @@ static void swPanelPowerSequence(int disp, int delay)
 	u32 reg;
 	u32 opt[] = {
 		PANEL_DISPLAY_CTRL_FPEN, PANEL_DISPLAY_CTRL_DATA,
-		PANEL_DISPLAY_CTRL_VBIASEN, PANEL_DISPLAY_CTRL_FPEN,
+		PANEL_DISPLAY_CTRL_VBIASEN, PANEL_DISPLAY_CTRL_FPVDDEN,
 	};
 	u32 size, i;
 
-- 
2.13.2

Re: [PATCH v2] staging: sm750fb: refactor method and fix potential type inconsistence

From: Greg KH <gregkh@linuxfoundation.org>
Date: 2017-07-03 06:20:43 

On Sun, Jul 02, 2017 at 10:40:33PM +0800, Lynn Lei wrote:
include PANEL_DISPLAY_CTRL_FPVDDEN control mask

Does the subject match this?
quoted hunk
Signed-off-by: Lynn Lei <redacted>
---
 drivers/staging/sm750fb/ddk750_display.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/staging/sm750fb/ddk750_display.c b/drivers/staging/sm750fb/ddk750_display.c
index 0f666dc2729a..c68367e6cdeb 100644
--- a/drivers/staging/sm750fb/ddk750_display.c
+++ b/drivers/staging/sm750fb/ddk750_display.c
@@ -89,7 +89,7 @@ static void swPanelPowerSequence(int disp, int delay)
 	u32 reg;
 	u32 opt[] = {
 		PANEL_DISPLAY_CTRL_FPEN, PANEL_DISPLAY_CTRL_DATA,
-		PANEL_DISPLAY_CTRL_VBIASEN, PANEL_DISPLAY_CTRL_FPEN,
+		PANEL_DISPLAY_CTRL_VBIASEN, PANEL_DISPLAY_CTRL_FPVDDEN,
Are you sure this is allowed?  Why is this patch correct?

And again, it doesn't match the subject line :(

greg k-h
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help