[PATCH] backlight: pwm_bl: make of_device_ids const

Subsystems: backlight class/subsystem, framebuffer layer, the rest

STALE3345d

5 messages, 5 authors, 2017-07-17 · open the first message on its own page

[PATCH] backlight: pwm_bl: make of_device_ids const

From: Arvind Yadav <hidden>
Date: 2017-06-20 07:52:57 

of_device_ids are not supposed to change at runtime. All functions
working with of_device_ids provided by <linux/of.h> work with const
of_device_ids. So mark the non-const structs as const.

Signed-off-by: Arvind Yadav <redacted>
---
 drivers/video/backlight/pwm_bl.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/video/backlight/pwm_bl.c b/drivers/video/backlight/pwm_bl.c
index 002f1ce..9bd1768 100644
--- a/drivers/video/backlight/pwm_bl.c
+++ b/drivers/video/backlight/pwm_bl.c
@@ -178,7 +178,7 @@ static int pwm_backlight_parse_dt(struct device *dev,
 	return 0;
 }
 
-static struct of_device_id pwm_backlight_of_match[] = {
+static const struct of_device_id pwm_backlight_of_match[] = {
 	{ .compatible = "pwm-backlight" },
 	{ }
 };
-- 
1.9.1

Re: [PATCH] backlight: pwm_bl: make of_device_ids const

From: Daniel Thompson <hidden>
Date: 2017-06-20 10:52:36 

On 20/06/17 08:52, Arvind Yadav wrote:
of_device_ids are not supposed to change at runtime. All functions
working with of_device_ids provided by <linux/of.h> work with const
of_device_ids. So mark the non-const structs as const.

Signed-off-by: Arvind Yadav <redacted>
Acked-by: Daniel Thompson <redacted>
quoted hunk
---
  drivers/video/backlight/pwm_bl.c | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/video/backlight/pwm_bl.c b/drivers/video/backlight/pwm_bl.c
index 002f1ce..9bd1768 100644
--- a/drivers/video/backlight/pwm_bl.c
+++ b/drivers/video/backlight/pwm_bl.c
@@ -178,7 +178,7 @@ static int pwm_backlight_parse_dt(struct device *dev,
  	return 0;
  }
  
-static struct of_device_id pwm_backlight_of_match[] = {
+static const struct of_device_id pwm_backlight_of_match[] = {
  	{ .compatible = "pwm-backlight" },
  	{ }
  };





  

    
Re: [PATCH] backlight: pwm_bl: make of_device_ids const

    

      From: "Jingoo Han" <jingoohan1@gmail.com>

      Date: 2017-06-20 13:59:12 
    

  

  
On Tuesday, June 20, 2017 6:53 AM, Daniel Thompson wrote:
On 20/06/17 08:52, Arvind Yadav wrote:
quoted
of_device_ids are not supposed to change at runtime. All functions
working with of_device_ids provided by <linux/of.h> work with const
of_device_ids. So mark the non-const structs as const.

Signed-off-by: Arvind Yadav <redacted>
Acked-by: Daniel Thompson <redacted>
Acked-by: Jingoo Han <jingoohan1@gmail.com>

Best regards,
Jingoo Han

quoted
---
  drivers/video/backlight/pwm_bl.c | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/video/backlight/pwm_bl.c
b/drivers/video/backlight/pwm_bl.c
quoted
index 002f1ce..9bd1768 100644
--- a/drivers/video/backlight/pwm_bl.c
+++ b/drivers/video/backlight/pwm_bl.c
@@ -178,7 +178,7 @@ static int pwm_backlight_parse_dt(struct device *dev,
  	return 0;
  }

-static struct of_device_id pwm_backlight_of_match[] = {
+static const struct of_device_id pwm_backlight_of_match[] = {
  	{ .compatible = "pwm-backlight" },
  	{ }
  };





  

    
Re: [PATCH] backlight: pwm_bl: make of_device_ids const

    

      From: Thierry Reding <hidden>

      Date: 2017-07-06 06:42:27 
    

  

  
On Tue, Jun 20, 2017 at 01:22:15PM +0530, Arvind Yadav wrote:
of_device_ids are not supposed to change at runtime. All functions
working with of_device_ids provided by <linux/of.h> work with const
of_device_ids. So mark the non-const structs as const.

Signed-off-by: Arvind Yadav <redacted>
---
 drivers/video/backlight/pwm_bl.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Acked-by: Thierry Reding <redacted>





  

    
Re: [PATCH] backlight: pwm_bl: make of_device_ids const

    

      From: Lee Jones <hidden>

      Date: 2017-07-17 12:21:50 
    

  

  
On Tue, 20 Jun 2017, Arvind Yadav wrote:

of_device_ids are not supposed to change at runtime. All functions
working with of_device_ids provided by <linux/of.h> work with const
of_device_ids. So mark the non-const structs as const.

Signed-off-by: Arvind Yadav <redacted>
---
 drivers/video/backlight/pwm_bl.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Applied, thanks.

quoted hunk
diff --git a/drivers/video/backlight/pwm_bl.c b/drivers/video/backlight/pwm_bl.c
index 002f1ce..9bd1768 100644
--- a/drivers/video/backlight/pwm_bl.c
+++ b/drivers/video/backlight/pwm_bl.c
@@ -178,7 +178,7 @@ static int pwm_backlight_parse_dt(struct device *dev,
 	return 0;
 }
 
-static struct of_device_id pwm_backlight_of_match[] = {
+static const struct of_device_id pwm_backlight_of_match[] = {
 	{ .compatible = "pwm-backlight" },
 	{ }
 };
-- 
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog




    
  

  
    

      

        Keyboard shortcuts
      

      

        
          
hback out one level

          
jnext message in thread

          
kprevious message in thread

          
ldrill in

          
Escclose help / fold thread tree

          
?toggle this help