[PATCH] drm: omapdrm: remove unused variable

Subsystems: framebuffer layer, omap display subsystem and framebuffer support (dss2), the rest

STALE3347d

2 messages, 2 authors, 2017-06-10 · open the first message on its own page

[PATCH] drm: omapdrm: remove unused variable

From: Arnd Bergmann <arnd@arndb.de>
Date: 2017-06-09 10:32:01

Removing the default display name left a harmless warning:

fbdev/omap2/omapfb/dss/core.c: In function 'omap_dss_probe':
fbdev/omap2/omapfb/dss/core.c:196:30: error: unused variable 'pdata' [-Werror=unused-variable]

This removes the now-unused variable as well.

Fixes: 278cba7eaf54 ("drm: omapdrm: Remove unused default display name support")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
 drivers/video/fbdev/omap2/omapfb/dss/core.c | 1 -
 1 file changed, 1 deletion(-)
diff --git a/drivers/video/fbdev/omap2/omapfb/dss/core.c b/drivers/video/fbdev/omap2/omapfb/dss/core.c
index eecf695c16f4..09e5bb013d28 100644
--- a/drivers/video/fbdev/omap2/omapfb/dss/core.c
+++ b/drivers/video/fbdev/omap2/omapfb/dss/core.c
@@ -193,7 +193,6 @@ static struct notifier_block omap_dss_pm_notif_block = {
 
 static int __init omap_dss_probe(struct platform_device *pdev)
 {
-	struct omap_dss_board_info *pdata = pdev->dev.platform_data;
 	int r;
 
 	core.pdev = pdev;
-- 
2.9.0

Re: [PATCH] drm: omapdrm: remove unused variable

From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Date: 2017-06-10 09:04:19

Hi Arnd,

Thank you for the patch.

On Friday 09 Jun 2017 12:31:03 Arnd Bergmann wrote:
Removing the default display name left a harmless warning:

fbdev/omap2/omapfb/dss/core.c: In function 'omap_dss_probe':
fbdev/omap2/omapfb/dss/core.c:196:30: error: unused variable 'pdata'
[-Werror=unused-variable]

This removes the now-unused variable as well.

Fixes: 278cba7eaf54 ("drm: omapdrm: Remove unused default display name
support")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
quoted hunk
---
 drivers/video/fbdev/omap2/omapfb/dss/core.c | 1 -
 1 file changed, 1 deletion(-)
diff --git a/drivers/video/fbdev/omap2/omapfb/dss/core.c
b/drivers/video/fbdev/omap2/omapfb/dss/core.c index
eecf695c16f4..09e5bb013d28 100644
--- a/drivers/video/fbdev/omap2/omapfb/dss/core.c
+++ b/drivers/video/fbdev/omap2/omapfb/dss/core.c
@@ -193,7 +193,6 @@ static struct notifier_block omap_dss_pm_notif_block = {

 static int __init omap_dss_probe(struct platform_device *pdev)
 {
-	struct omap_dss_board_info *pdata = pdev->dev.platform_data;
 	int r;

 	core.pdev = pdev;
-- 
Regards,

Laurent Pinchart
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help