[PATCH] video: fbdev: pxafb: Handle return value of clk_prepare_enable

Subsystems: framebuffer layer, the rest

STALE3342d

2 messages, 2 authors, 2017-06-14 · open the first message on its own page

[PATCH] video: fbdev: pxafb: Handle return value of clk_prepare_enable

From: Arvind Yadav <hidden>
Date: 2017-06-07 09:52:53

clk_prepare_enable() can fail here and we must check its return value.

Signed-off-by: Arvind Yadav <redacted>
---
 drivers/video/fbdev/pxafb.c | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/drivers/video/fbdev/pxafb.c b/drivers/video/fbdev/pxafb.c
index b21a89b..c3d49e1 100644
--- a/drivers/video/fbdev/pxafb.c
+++ b/drivers/video/fbdev/pxafb.c
@@ -1436,7 +1436,10 @@ static void pxafb_enable_controller(struct pxafb_info *fbi)
 	pr_debug("reg_lccr3 0x%08x\n", (unsigned int) fbi->reg_lccr3);
 
 	/* enable LCD controller clock */
-	clk_prepare_enable(fbi->clk);
+	if (clk_prepare_enable(fbi->clk)) {
+		pr_err("%s: Failed to prepare clock\n", __func__);
+		return;
+	}
 
 	if (fbi->lccr0 & LCCR0_LCDT)
 		return;
-- 
1.9.1

Re: [PATCH] video: fbdev: pxafb: Handle return value of clk_prepare_enable

From: Bartlomiej Zolnierkiewicz <hidden>
Date: 2017-06-14 14:48:57

On Wednesday, June 07, 2017 03:22:09 PM Arvind Yadav wrote:
clk_prepare_enable() can fail here and we must check its return value.

Signed-off-by: Arvind Yadav <redacted>
Patch queued for 4.13, thanks.

Best regards,
--
Bartlomiej Zolnierkiewicz
Samsung R&D Institute Poland
Samsung Electronics
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help