# \[PATCH\] video: fbdev: pmag-aa-fb: remove incorrect \_\_exit markups

- Subsystems: FRAMEBUFFER LAYER, THE REST
- Maintainers: Helge Deller, Linus Torvalds
- List: linux-fbdev
- 3 messages, 3 authors
- Page: https://ratatoskr.run/linux-fbdev/2017/03/4944683/t

## \[PATCH\] video: fbdev: pmag-aa-fb: remove incorrect \_\_exit markups

- From: Dmitry Torokhov \<dmitry.torokhov@gmail.com\>
- Date: 2017-03-02 00:08:04 
- Message: https://ratatoskr.run/linux-fbdev/2017/03/4944683.md

```text
Even if bus is not hot-pluggable, devices can be unbound from the
driver via sysfs, so we should not be using __exit annotations on
remove() methods. The only exception is drivers registered with
platform_driver_probe() which specifically disables sysfs bind/unbind
attributes.

Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
---
 drivers/video/fbdev/pmag-aa-fb.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/video/fbdev/pmag-aa-fb.c b/drivers/video/fbdev/pmag-aa-fb.c
index ffe2dd482f84..39922f072db4 100644
--- a/drivers/video/fbdev/pmag-aa-fb.c
+++ b/drivers/video/fbdev/pmag-aa-fb.c
@@ -247,7 +247,7 @@ static int pmagaafb_probe(struct device *dev)
 	return err;
 }
 
-static int __exit pmagaafb_remove(struct device *dev)
+static int pmagaafb_remove(struct device *dev)
 {
 	struct tc_dev *tdev = to_tc_dev(dev);
 	struct fb_info *info = dev_get_drvdata(dev);
@@ -280,7 +280,7 @@ static struct tc_driver pmagaafb_driver = {
 		.name	= "pmagaafb",
 		.bus	= &tc_bus_type,
 		.probe	= pmagaafb_probe,
-		.remove	= __exit_p(pmagaafb_remove),
+		.remove	= pmagaafb_remove,
 	},
 };
 
-- 
2.12.0.rc1.440.g5b76565f74-goog


-- 
Dmitry
```

## Re: \[PATCH\] video: fbdev: pmag-aa-fb: remove incorrect \_\_exit markups

- From: Bartlomiej Zolnierkiewicz \<hidden\>
- Date: 2017-03-20 17:01:13 
- Message: https://ratatoskr.run/linux-fbdev/2017/03/4958887.md

```text
On Wednesday, March 01, 2017 03:31:09 PM Dmitry Torokhov wrote:
> Even if bus is not hot-pluggable, devices can be unbound from the
> driver via sysfs, so we should not be using __exit annotations on
> remove() methods. The only exception is drivers registered with
> platform_driver_probe() which specifically disables sysfs bind/unbind
> attributes.
> 
> Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>

Patch queued for 4.12, thanks.

Best regards,
--
Bartlomiej Zolnierkiewicz
Samsung R&D Institute Poland
Samsung Electronics

```

## Re: \[PATCH\] video: fbdev: pmag-aa-fb: remove incorrect \_\_exit markups

- From: Maciej W. Rozycki \<hidden\>
- Date: 2017-03-23 11:48:58 
- Message: https://ratatoskr.run/linux-fbdev/2017/03/4961568.md

```text
On Mon, 20 Mar 2017, Bartlomiej Zolnierkiewicz wrote:

> > Even if bus is not hot-pluggable, devices can be unbound from the
> > driver via sysfs, so we should not be using __exit annotations on
> > remove() methods. The only exception is drivers registered with
> > platform_driver_probe() which specifically disables sysfs bind/unbind
> > attributes.
> > 
> > Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
> 
> Patch queued for 4.12, thanks.

 Thanks!

  Maciej
```