# Re: \[PATCH 4/5\] staging: sm750fb: Remove unnecessary else after return

- From: Joe Perches \<joe@perches.com\>
- Date: 2017-02-27 19:32:31 
- List: linux-fbdev
- Page: https://ratatoskr.run/linux-fbdev/2017/02/4942428
- Thread: https://ratatoskr.run/linux-fbdev/2017/02/4942386/t.md

```text
On Mon, 2017-02-27 at 23:44 +0530, simran singhal wrote:
> This patch fixes the checkpatch warning that else is not generally
> useful after a break or return.
[]
> diff --git a/drivers/staging/sm750fb/ddk750_swi2c.c b/drivers/staging/sm750fb/ddk750_swi2c.c
[]
> @@ -295,8 +294,7 @@ static long sw_i2c_write_byte(unsigned char data)
>  
>  	if (i < 0xff)
>  		return 0;
> -	else
> -		return -1;
> +	return -1;

Assuming -1 is some sort of error,
it'd be a more common style to use

	if (i >= 0xff)
		return -1;

	return 0;

Looking at the code, it might make
sense to use something like:

	/* SDA still != 0 */
	if (i >= 0xff)
		return -1;

	return 0;
}
```