[PATCH -next] video: fbdev: sh_mobile_lcdcfb: fix error return code in sh_mobile_lcdc_probe()

From: Wei Yongjun <redacted>

Fix to return error code -ENODEV from the ioremap_nocache() error
handling case instead of 0, as done elsewhere in this function.

Signed-off-by: Wei Yongjun <redacted>
---
 drivers/video/fbdev/sh_mobile_lcdcfb.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/drivers/video/fbdev/sh_mobile_lcdcfb.c b/drivers/video/fbdev/sh_mobile_lcdcfb.c
index 93469f9..ea8b6d5 100644
--- a/drivers/video/fbdev/sh_mobile_lcdcfb.c
+++ b/drivers/video/fbdev/sh_mobile_lcdcfb.c

@@ -2782,8 +2782,10 @@ static int sh_mobile_lcdc_probe(struct platform_device *pdev)
 		priv->forced_fourcc = pdata->ch[0].fourcc;
 
 	priv->base = ioremap_nocache(res->start, resource_size(res));
-	if (!priv->base)
+	if (!priv->base) {
+		error = -ENODEV;
 		goto err1;
+	}
 
 	error = sh_mobile_lcdc_setup_clocks(priv, pdata->clock_source);
 	if (error) {

On Mon, Feb 6, 2017 at 3:24 PM, Wei Yongjun [off-list ref] wrote:

From: Wei Yongjun <redacted>

Fix to return error code -ENODEV from the ioremap_nocache() error
handling case instead of 0, as done elsewhere in this function.

Signed-off-by: Wei Yongjun <redacted>

If you fix the minor nit below:
Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>

-ENOMEM is more appropriate for this kind of failure.

                goto err1;
+       }

        error = sh_mobile_lcdc_setup_clocks(priv, pdata->clock_source);
        if (error) {

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds