Re: [PATCH] fbdev: ssd1307fb: allow reset-gpios is missing

On Mon, Jan 16, 2017 at 05:50:21PM +0800, Icenowy Zheng wrote:

2017年1月16日 16:02于 Maxime Ripard [off-list ref]写道：

quoted

On Sun, Jan 15, 2017 at 07:21:46PM +0800, Icenowy Zheng wrote: 

quoted

Currently some SSD1306 OLED modules are sold without a reset pin (only 
VCC, GND, SCK, SDA four pins). 

Add support for missing reset-gpios property. 

Signed-off-by: Icenowy Zheng <redacted> 

Unfortunately, a similar patch has been sent a couple of times 
already: 
https://www.spinics.net/lists/devicetree/msg158330.html 

Why is it never merged?

It was sent 4 days ago...

And since you didn't have the right maintainers in the cc list, yours
didn't have a chance to be merged either.
 

There are really boards that needs this function.

Then  you can accelerate its inclusion by reviewing it.

Maxime

-- 
Maxime Ripard, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com

On Tue, Jan 17, 2017 at 9:40 AM, Maxime Ripard
[off-list ref] wrote:

On Mon, Jan 16, 2017 at 05:50:21PM +0800, Icenowy Zheng wrote:

quoted

2017年1月16日 16:02于 Maxime Ripard [off-list ref]写道：

quoted

On Sun, Jan 15, 2017 at 07:21:46PM +0800, Icenowy Zheng wrote:

quoted

Currently some SSD1306 OLED modules are sold without a reset pin (only
VCC, GND, SCK, SDA four pins).

Add support for missing reset-gpios property.

Signed-off-by: Icenowy Zheng <redacted>

Unfortunately, a similar patch has been sent a couple of times
already:
https://www.spinics.net/lists/devicetree/msg158330.html

Why is it never merged?

It was sent 4 days ago...

And since you didn't have the right maintainers in the cc list, yours
didn't have a chance to be merged either.

quoted

There are really boards that needs this function.

Then  you can accelerate its inclusion by reviewing it.

Perhaps someone eventually adds drivers/reset/reset-gpio.c and uses
devm_get_reset_optional_exclusive() instead?


-- 
With Best Regards,
Andy Shevchenko