# Re: \[PATCH v2\] video: imxfb: remove the macros for initializing the DMACR

- From: Bartlomiej Zolnierkiewicz \<hidden\>
- Date: 2017-01-11 12:40:13 
- List: linux-fbdev
- Page: https://ratatoskr.run/linux-fbdev/2017/01/4909831
- Thread: https://ratatoskr.run/linux-fbdev/2016/11/4880281/t.md

```text

Hi,

On Tuesday, November 29, 2016 08:57:21 PM Uwe Kleine-König wrote:
> On Tue, Nov 29, 2016 at 08:50:39PM +0100, Martin Kaiser wrote:
> > The current definitions of DMACR_HM() and DMACR_TM() are correct only
> > for imx1, they're wrong for imx21.
> > 
> > The macros are meant for legacy board files only, they're not applicable
> > for boards using device tree.
> > 
> > At the moment, there are no boards using these macros. So it should be
> > safe to drop them rather than making them work for both imx1 and imx21,
> > which would require a change in the platform data struct.
> > 
> > Signed-off-by: Martin Kaiser <redacted>
> Acked-by: Uwe Kleine-König <redacted>

Thanks, queued for 4.11.

Best regards,
--
Bartlomiej Zolnierkiewicz
Samsung R&D Institute Poland
Samsung Electronics

```