# \[PATCH\] video: fbdev: maxinefb: add \_\_initdata to maxinefb\_fix

- Subsystems: FRAMEBUFFER LAYER, THE REST
- Maintainers: Helge Deller, Linus Torvalds
- List: linux-fbdev
- 2 messages, 2 authors
- Page: https://ratatoskr.run/linux-fbdev/2017/01/4902237/t

## \[PATCH\] video: fbdev: maxinefb: add \_\_initdata to maxinefb\_fix

- From: Bhumika Goyal \<hidden\>
- Date: 2017-01-01 16:36:40 
- Message: https://ratatoskr.run/linux-fbdev/2017/01/4902237.md

```text
The object maxinefb_fix of type fb_fix_screeninfo is never referenced
after initialization by maxinefb_init. In the init function, the object
and one of its fields is only stored into another variable. So, the
object and its fields are never referenced anywhere after initialization
and therefore add __initdata to its declaration.

Signed-off-by: Bhumika Goyal <redacted>
---
 drivers/video/fbdev/maxinefb.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/video/fbdev/maxinefb.c b/drivers/video/fbdev/maxinefb.c
index 5cf52d3..cab7333 100644
--- a/drivers/video/fbdev/maxinefb.c
+++ b/drivers/video/fbdev/maxinefb.c
@@ -51,7 +51,7 @@
 	.vmode =	FB_VMODE_NONINTERLACED,
 };
 
-static struct fb_fix_screeninfo maxinefb_fix = {
+static struct fb_fix_screeninfo maxinefb_fix __initdata = {
 	.id =		"Maxine",
 	.smem_len =	(1024*768),
 	.type =		FB_TYPE_PACKED_PIXELS,
-- 
1.9.1

```

## Re: \[PATCH\] video: fbdev: maxinefb: add \_\_initdata to maxinefb\_fix

- From: Bartlomiej Zolnierkiewicz \<hidden\>
- Date: 2017-01-11 13:02:11 
- Message: https://ratatoskr.run/linux-fbdev/2017/01/4909844.md

```text

Hi,

On Sunday, January 01, 2017 10:06:17 PM Bhumika Goyal wrote:
> The object maxinefb_fix of type fb_fix_screeninfo is never referenced
> after initialization by maxinefb_init. In the init function, the object
> and one of its fields is only stored into another variable. So, the
> object and its fields are never referenced anywhere after initialization
> and therefore add __initdata to its declaration.
> 
> Signed-off-by: Bhumika Goyal <redacted>

Thanks, queued fpr 4.11.

Best regards,
--
Bartlomiej Zolnierkiewicz
Samsung R&D Institute Poland
Samsung Electronics

> ---
>  drivers/video/fbdev/maxinefb.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/video/fbdev/maxinefb.c b/drivers/video/fbdev/maxinefb.c
> index 5cf52d3..cab7333 100644
> --- a/drivers/video/fbdev/maxinefb.c
> +++ b/drivers/video/fbdev/maxinefb.c
> @@ -51,7 +51,7 @@
>  	.vmode =	FB_VMODE_NONINTERLACED,
>  };
>  
> -static struct fb_fix_screeninfo maxinefb_fix = {
> +static struct fb_fix_screeninfo maxinefb_fix __initdata = {
>  	.id =		"Maxine",
>  	.smem_len =	(1024*768),
>  	.type =		FB_TYPE_PACKED_PIXELS,

```
