# Re: \[PATCH\] video: imxfb: remove the macros for initializing the DMACR

- From: Uwe Kleine-König \<hidden\>
- Date: 2016-11-29 07:50:01 
- List: linux-fbdev
- Page: https://ratatoskr.run/linux-fbdev/2016/11/4884979
- Thread: https://ratatoskr.run/linux-fbdev/2016/11/4880281/t.md

```text
On Mon, Nov 28, 2016 at 11:43:09PM +0100, Martin Kaiser wrote:
> The current definitions of DMACR_HM() and DMACR_TM() are correct only
> for imx1, they're wrong for imx21.
> 
> The macros are meant for legacy board files only, they're not applicable
> for boards using device tree.
> 
> At the moment, there are no boards are using the macros. So it should be
s/are using the/using these/

> safe to drop them rather than making them work for both imx1 and imx21,
> which would require a change in the platform data struct.
> 
> Signed-off-by: Martin Kaiser <redacted>
Acked-by: Uwe Kleine-König <redacted>

Best regards
Uwe

-- 
Pengutronix e.K.                           | Uwe Kleine-König            |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
```
