# \[PATCH\] video: fbdev: add missing \\n at end of printk error message

- Subsystems: FRAMEBUFFER LAYER, EPSON S1D13XXX FRAMEBUFFER DRIVER, THE REST
- Maintainers: Helge Deller, Kristoffer Ericson, Linus Torvalds
- List: linux-fbdev
- 2 messages, 2 authors
- Page: https://ratatoskr.run/linux-fbdev/2016/09/4833649/t

## \[PATCH\] video: fbdev: add missing \\n at end of printk error message

- From: Colin King \<hidden\>
- Date: 2016-09-12 10:25:53 
- Message: https://ratatoskr.run/linux-fbdev/2016/09/4833649.md

```text
From: Colin Ian King <redacted>

The message is missing a \n, add it.

Signed-off-by: Colin Ian King <redacted>
---
 drivers/video/fbdev/s1d13xxxfb.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/video/fbdev/s1d13xxxfb.c b/drivers/video/fbdev/s1d13xxxfb.c
index 96aa46d..6a271d8 100644
--- a/drivers/video/fbdev/s1d13xxxfb.c
+++ b/drivers/video/fbdev/s1d13xxxfb.c
@@ -929,7 +929,7 @@ static int s1d13xxxfb_suspend(struct platform_device *dev, pm_message_t state)
 		s1dfb->disp_save = kmalloc(info->fix.smem_len, GFP_KERNEL);
 
 	if (!s1dfb->disp_save) {
-		printk(KERN_ERR PFX "no memory to save screen");
+		printk(KERN_ERR PFX "no memory to save screen\n");
 		return -ENOMEM;
 	}
 
-- 
2.9.3

```

## Re: \[PATCH\] video: fbdev: add missing \\n at end of printk error message

- From: Tomi Valkeinen \<hidden\>
- Date: 2016-09-27 08:09:03 
- Message: https://ratatoskr.run/linux-fbdev/2016/09/4844379.md

```text
On 12/09/16 13:24, Colin King wrote:
> From: Colin Ian King <redacted>
> 
> The message is missing a \n, add it.
> 
> Signed-off-by: Colin Ian King <redacted>
> ---
>  drivers/video/fbdev/s1d13xxxfb.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/video/fbdev/s1d13xxxfb.c b/drivers/video/fbdev/s1d13xxxfb.c
> index 96aa46d..6a271d8 100644
> --- a/drivers/video/fbdev/s1d13xxxfb.c
> +++ b/drivers/video/fbdev/s1d13xxxfb.c
> @@ -929,7 +929,7 @@ static int s1d13xxxfb_suspend(struct platform_device *dev, pm_message_t state)
>  		s1dfb->disp_save = kmalloc(info->fix.smem_len, GFP_KERNEL);
>  
>  	if (!s1dfb->disp_save) {
> -		printk(KERN_ERR PFX "no memory to save screen");
> +		printk(KERN_ERR PFX "no memory to save screen\n");
>  		return -ENOMEM;
>  	}
>  
> 

Thanks, queued for 4.9.

 Tomi

```
