# Re: \[PATCH\] video: fbdev: intelfb: remove impossible condition

- From: Tomi Valkeinen \<hidden\>
- Date: 2016-09-07 08:17:38 
- List: linux-fbdev
- Page: https://ratatoskr.run/linux-fbdev/2016/09/4830541
- Thread: https://ratatoskr.run/linux-fbdev/2016/08/4825944/t.md

```text
On 31/08/16 18:44, Sudip Mukherjee wrote:
> xoffset and yoffset of struct fb_var_screeninfo are unsigned and so
> they can never be less than 0.
> 
> Signed-off-by: Sudip Mukherjee <sudip.mukherjee@codethink.co.uk>
> ---
>  drivers/video/fbdev/intelfb/intelfbdrv.c | 5 -----
>  1 file changed, 5 deletions(-)
> 
> diff --git a/drivers/video/fbdev/intelfb/intelfbdrv.c b/drivers/video/fbdev/intelfb/intelfbdrv.c
> index bf20744..ff2a5d2 100644
> --- a/drivers/video/fbdev/intelfb/intelfbdrv.c
> +++ b/drivers/video/fbdev/intelfb/intelfbdrv.c
> @@ -1301,11 +1301,6 @@ static int intelfb_check_var(struct fb_var_screeninfo *var,
>  		break;
>  	}
>  
> -	if (v.xoffset < 0)
> -		v.xoffset = 0;
> -	if (v.yoffset < 0)
> -		v.yoffset = 0;
> -
>  	if (v.xoffset > v.xres_virtual - v.xres)
>  		v.xoffset = v.xres_virtual - v.xres;
>  	if (v.yoffset > v.yres_virtual - v.yres)
> 

Thanks, queued for 4.9.

 Tomi

```

## Attachments

- [signature.asc](https://ratatoskr.run/linux-fbdev/2016/09/4830541/attachment/0) (application/pgp-signature, 819 bytes)