# Re: \[PATCH\] omapfb: fix return value check in dsi\_bind()

- From: Tomi Valkeinen \<hidden\>
- Date: 2016-09-27 08:04:48 
- List: linux-fbdev
- Page: https://ratatoskr.run/linux-fbdev/2016/09/13466604
- Thread: https://ratatoskr.run/linux-fbdev/2016/09/13466602/t.md

```text
On 17/09/16 18:53, Wei Yongjun wrote:
> From: Wei Yongjun <redacted>
> 
> Fix the retrn value check which testing the wrong variable
> in dsi_bind().
> 
> Fixes: f76ee892a99e ("omapfb: copy omapdss & displays for omapfb")
> Signed-off-by: Wei Yongjun <redacted>
> ---
>  drivers/video/fbdev/omap2/omapfb/dss/dsi.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/video/fbdev/omap2/omapfb/dss/dsi.c b/drivers/video/fbdev/omap2/omapfb/dss/dsi.c
> index 9e4800a..951dd93 100644
> --- a/drivers/video/fbdev/omap2/omapfb/dss/dsi.c
> +++ b/drivers/video/fbdev/omap2/omapfb/dss/dsi.c
> @@ -5348,7 +5348,7 @@ static int dsi_bind(struct device *dev, struct device *master, void *data)
>  
>  	dsi->phy_base = devm_ioremap(&dsidev->dev, res->start,
>  		resource_size(res));
> -	if (!dsi->proto_base) {
> +	if (!dsi->phy_base) {
>  		DSSERR("can't ioremap DSI PHY\n");
>  		return -ENOMEM;
>  	}
> @@ -5368,7 +5368,7 @@ static int dsi_bind(struct device *dev, struct device *master, void *data)
>  
>  	dsi->pll_base = devm_ioremap(&dsidev->dev, res->start,
>  		resource_size(res));
> -	if (!dsi->proto_base) {
> +	if (!dsi->pll_base) {
>  		DSSERR("can't ioremap DSI PLL\n");
>  		return -ENOMEM;
>  	}
> 

Thanks, queued for 4.9.

 Tomi

```

## Attachments

- [signature.asc](https://ratatoskr.run/linux-fbdev/2016/09/13466604/attachment/0) (application/pgp-signature, 819 bytes)